Ubuntu
rhythmbox package

Merge lp://qastaging/~l3on/ubuntu/quantal/rhythmbox/lyrics-fixes into lp://qastaging/ubuntu/quantal/rhythmbox

  1. Quantal (12.10)
  2. lyrics-fixes
  3. Merge into quantal
Proposed by Leo Iannacone
Status: Work in progress
Proposed branch: lp://qastaging/~l3on/ubuntu/quantal/rhythmbox/lyrics-fixes
Merge into: lp://qastaging/ubuntu/quantal/rhythmbox
Diff against target: 981 lines (+709/-36)
17 files modified
.pc/applied-patches (+6/-0)
debian/changelog (+17/-0)
debian/patches/20_fix_darklyrics_parser.patch (+94/-0)
debian/patches/21_disable_lyrics_service.patch (+30/-0)
debian/patches/22_fix_lyrics_dialog.patch (+19/-0)
debian/patches/23_lyrics_fix_terraparser.patch (+148/-0)
debian/patches/24_add_lyricsreg_service.patch (+167/-0)
debian/patches/25_fix_links_tab.patch (+18/-0)
debian/patches/series (+6/-0)
plugins/context/LinksTab.py (+1/-0)
plugins/lyrics/DarkLyricsParser.py (+15/-11)
plugins/lyrics/LyricsConfigureDialog.py (+1/-1)
plugins/lyrics/LyricsRegParser.py (+110/-0)
plugins/lyrics/LyricsSites.py (+2/-5)
plugins/lyrics/Makefile.am (+2/-1)
plugins/lyrics/Makefile.in (+2/-1)
plugins/lyrics/TerraParser.py (+71/-17)
To merge this branch: bzr merge lp://qastaging/~l3on/ubuntu/quantal/rhythmbox/lyrics-fixes
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Needs Resubmitting
Ubuntu branches Pending
Review via email: mp+128362@code.qastaging.launchpad.net

Description of the change

This is a set of patches to improve lyrics plugin.

See the bugs for more info.

If you're agree I will submit patches to rhythmbox developers.

To post a comment you must log in.
lp://qastaging/~l3on/ubuntu/quantal/rhythmbox/lyrics-fixes updated
221. By Leo Iannacone

Fix install LyricsRegParser.py

222. By Leo Iannacone

Fix copyright assignments

Revision history for this message
Martin Pitt (pitti) wrote :

Can you please forward these to upstream's bugzilla and discuss the patches with upstream first? They are in a better position to judge the code and changes. Thanks!

Reply
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks like the bugs were reported upstream, and at this point some have been accepted or otherwise fixed upstream except for others in review; with the exception of bug 1062919 (which I'm not sure qualifies as SRU at this point).

I'll mark this Work in progress to note that there is still work being done on this branch; in the meantime, could you please resubmit to target quantal-proposed/fix the version numbering for SRU, so that we get closer to being able to ship these fixes as soon as they confirmed acceptable upstream? (but I'd follow http://wiki.ubuntu.com/StableReleaseUpdates#Procedures for all, and probably drop 1062919 until R)

Just set it back to Needs Review when done.

Also, feel free to submit the fix for bug 1062919 for R as soon as the release is open :)

review: Needs Resubmitting
Reply

Unmerged revisions

222. By Leo Iannacone

Fix copyright assignments

221. By Leo Iannacone

Fix install LyricsRegParser.py

220. By Leo Iannacone

* debian/patches/20_fix_darklyrics_parser.patch: update DarkLyrics parser
  according whit the new HTML structure of the website. (LP: #1062266)
* debian/patches/21_disable_lyrics_service.patch: remove some service
  that at the moment no longer work. (LP: #1062353 LP: #1062337)
* debian/patches/22_fix_lyrics_dialog.patch: self.dialog does not exist.
  Use the correct gdk.window for modal. (LP: #1062794)
* debian/patches/23_lyrics_fix_terraparser.patch: improve TerraParser
  for a better and more accurate search. (LP: #1062356)
* debian/patches/24_add_lyricsreg_service.patch: add a new lyrics
  service for LyricsReg website. (LP: #1062919)
* debian/patches/25_fix_links_tab.patch: correct import rb in tab Links
  (LP: #1062257)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: