MAAS

Merge lp://qastaging/~lamont/maas/bug-1669213 into lp://qastaging/~maas-committers/maas/trunk

  1. bug-1669213
  2. Merge into trunk
Proposed by LaMont Jones
Status: Merged
Approved by: LaMont Jones
Approved revision: no longer in the source branch.
Merged at revision: 5776
Proposed branch: lp://qastaging/~lamont/maas/bug-1669213
Merge into: lp://qastaging/~maas-committers/maas/trunk
Diff against target: 157 lines (+50/-10)
3 files modified
src/maasserver/static/js/angular/controllers/node_details_networking.js (+12/-2)
src/maasserver/static/js/angular/controllers/tests/test_node_details_networking.js (+31/-1)
src/maasserver/static/partials/node-details.html (+7/-7)
To merge this branch: bzr merge lp://qastaging/~lamont/maas/bug-1669213
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Review via email: mp+318819@code.qastaging.launchpad.net

Commit message

Correctly set initial subnet for device details interface edit.

Description of the change

Correctly set initial subnet for device details interface edit.

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Comments inline.

review: Needs Information
Revision history for this message
LaMont Jones (lamont) wrote :

I'm open to suggestions to better name the variable.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm! Does this address the adding a new interface bug where the 'save' button was not available?

review: Approve
Revision history for this message
LaMont Jones (lamont) wrote :

> lgtm! Does this address the adding a new interface bug where the 'save' button
> was not available?

Yes. That was the s/mac_address/macAddress/ change. Because newInteraface and editInterface use different values for the field. sigh.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.