Indicator Applet

Merge lp://qastaging/~laney/indicator-applet/invert-new-style-indicators into lp://qastaging/indicator-applet/13.10

  1. invert-new-style-indicators
  2. Merge into trunk.13.10
Proposed by Iain Lane
Status: Merged
Approved by: Lars Karlitski
Approved revision: 414
Merged at revision: 415
Proposed branch: lp://qastaging/~laney/indicator-applet/invert-new-style-indicators
Merge into: lp://qastaging/indicator-applet/13.10
Diff against target: 70 lines (+13/-12)
1 file modified
src/applet-main.c (+13/-12)
To merge this branch: bzr merge lp://qastaging/~laney/indicator-applet/invert-new-style-indicators
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Alberts Muktupāvels Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+177258@code.qastaging.launchpad.net

Commit message

Only prioritise and invert new-style indicators

Description of the change

Only the new-style indicators need to be inverted without changes to the logic in place_in_menu_cb. The diff over r409 is probably better to look at than this.

I also copied the static order table from u-p-s to refresh it.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:413
http://jenkins.qa.ubuntu.com/job/indicator-applet-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-applet-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-applet-saucy-armhf-ci/1

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-applet-ci/9/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Why are older indicators that have already been supplanted (libdatetime.so, libsession.so, libpower.so) added back in by this patch?

lp://qastaging/~laney/indicator-applet/invert-new-style-indicators updated
414. By Iain Lane

Remove new-style indicators from static order list.

Revision history for this message
Iain Lane (laney) wrote :

On Sat, Jul 27, 2013 at 08:29:29PM -0000, Charles Kerr wrote:
> Why are older indicators that have already been supplanted (libdatetime.so, libsession.so, libpower.so) added back in by this patch?

I just copied the list from unity-panel-service.

Let me remove them.

,----
| Pushed up to revision 414.
 `----

There we go.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:414
http://jenkins.qa.ubuntu.com/job/indicator-applet-ci/10/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-applet-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-applet-saucy-armhf-ci/2

Click here to trigger a rebuild:
http://s-jenkins:8080/job/indicator-applet-ci/10/rebuild

review: Approve (continuous-integration)
Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

I submitted almost identical change almost 10 days ago - https://code.launchpad.net/~albertsmuktupavels/indicator-applet/indicator-applet/+merge/175760

I will delete my branch when this will be approved.

Revision history for this message
Iain Lane (laney) wrote :

On Sun, Jul 28, 2013 at 04:44:23PM -0000, Alberts Muktupāvels wrote:
> I submitted almost identical change almost 10 days ago - https://code.launchpad.net/~albertsmuktupavels/indicator-applet/indicator-applet/+merge/175760
>
> I will delete my branch when this will be approved.

Oops sorry, I didn't see that :(

Thanks for your work on -applet :-)

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Alberts Muktupāvels (muktupavels) wrote :

Why it takes so long to approve changes? Currently indicators are in wrong positions because of my mistake. :(

review: Approve
Revision history for this message
Lars Karlitski (larsu) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches