Ubuntu Software Center

Merge lp://qastaging/~laney/software-center/webkit2 into lp://qastaging/software-center

  1. webkit2
  2. Merge into trunk
Proposed by Iain Lane
Status: Merged
Merged at revision: 3344
Proposed branch: lp://qastaging/~laney/software-center/webkit2
Merge into: lp://qastaging/software-center
Diff against target: 857 lines (+151/-293)
11 files modified
debian/control (+1/-1)
run-tests.sh (+2/-2)
softwarecenter/ui/gtk3/dialogs/dialog_tos.py (+15/-10)
softwarecenter/ui/gtk3/views/purchaseview.py (+22/-51)
softwarecenter/ui/gtk3/widgets/exhibits.py (+36/-36)
softwarecenter/ui/gtk3/widgets/videoplayer.py (+20/-79)
softwarecenter/ui/gtk3/widgets/webkit.py (+45/-67)
tests/gtk3/test_purchase.py (+0/-24)
tests/gtk3/test_webkit.py (+8/-18)
tests/gtk3/test_widgets.py (+1/-1)
tests/gtk3/windows.py (+1/-4)
To merge this branch: bzr merge lp://qastaging/~laney/software-center/webkit2
Reviewer Review Type Date Requested Status
Iain Lane (community) Approve
software-store-developers Pending
Review via email: mp+264723@code.qastaging.launchpad.net

Commit message

Port to WebKit 2

Description of the change

Initial review appreciated. There are probably still bugs (I didn't test purchasing for example).

To post a comment you must log in.
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This is great to see. I suggest testing these things:

* Does a purchase work?

* Does submitting a review work? (This should be fine, since the line you removed from submit_review.ui was also removed to fix bug 1445745.)

* Does an app's developer/support Web site link open in your default browser as expected?

* Does the checkbox list of add-ons show up for an app that has them? (Geany is a good example.)

lp://qastaging/~laney/software-center/webkit2 updated
3325. By dobey

Fix the version string to not be so high (no previous releases of it).

3326. By Sebastien Bacher

Remove use of deprecated n_row property.

3327. By Sebastien Bacher

Use GtkIcon's lookup_icon method instead of has_icon to fix invalid icons.

3328. By Michael Vogt

Avoid a crash when the aptdaemon transaction has no package data.

3329. By Sebastien Bacher

Clear some source ID warnings.

3330. By Sebastien Bacher

Restore the GtkStyle context in the button widget.

3331. By Sebastien Bacher

Remove gwibber usage.

3332. By Sebastien Bacher

DB_NOMMAP needs to be set using set_flags, it's not valid in DBEnv.open

3333. By dobey

Multi-inherit from object as well, as RawConfigParser is old-style.
Use super to chain up initialization.

3334. By Barry Warsaw

Fix some bilingual Python 2/3 issues so plug-ins can work in both versions.

3335. By Iain Lane

Open cataloged_times.p as bytes for py3 compatibility.

3336. By Michael Vogt

Disable paste when search entry not visible.

3337. By Bruce Pieterse

Update README to mentione python3-aptdaemon.test instead.

3338. By Bruce Pieterse

Added support for Adwaita Dark Theme Variant.

3339. By dobey

Merge the debian tree in for CI train landing support.

3340. By dobey

Prepare the release.

3341. By CI Train Bot Account

Releasing 16.01+16.04.20160107.1

3342. By Iain Lane

Patch from Robin van der Vilet to not crash on locales with no country. Fixes: #1510237

3343. By CI Train Bot Account

Releasing 16.01+16.04.20160119

3344. By Iain Lane

Merge with trunk again

Revision history for this message
Iain Lane (laney) wrote :

Self approving - if you have feedback we can address in later rounds.

review: Approve
Revision history for this message
dobey (dobey) wrote :

Can you answer mpt's questions?

Revision history for this message
Iain Lane (laney) wrote :

On Wed, Feb 17, 2016 at 03:40:03PM -0000, Rodney Dawes wrote:
> Can you answer mpt's questions?

ok

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Revision history for this message
Iain Lane (laney) wrote :

On Tue, Jul 28, 2015 at 07:45:03AM -0000, Matthew Paul Thomas wrote:
> This is great to see. I suggest testing these things:
>
> * Does a purchase work?

I don't know how to purchase anything - is there a test server with some
packages available for xenial?

> * Does submitting a review work? (This should be fine, since the line you removed from submit_review.ui was also removed to fix bug 1445745.)

Yeah

> * Does an app's developer/support Web site link open in your default browser as expected?

Yeah

> * Does the checkbox list of add-ons show up for an app that has them? (Geany is a good example.)

Yeah

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.