ubuntu-system-settings

Merge lp://qastaging/~laney/ubuntu-system-settings/click-changelogs into lp://qastaging/ubuntu-system-settings

  1. click-changelogs
  2. Merge into trunk
Proposed by Iain Lane
Status: Work in progress
Proposed branch: lp://qastaging/~laney/ubuntu-system-settings/click-changelogs
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 129 lines (+41/-8)
3 files modified
plugins/system-update/PageComponent.qml (+33/-8)
plugins/system-update/network/network.cpp (+2/-0)
plugins/system-update/update.h (+6/-0)
To merge this branch: bzr merge lp://qastaging/~laney/ubuntu-system-settings/click-changelogs
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Diego Sarmentero Pending
Ubuntu Touch System Settings Pending
Review via email: mp+220502@code.qastaging.launchpad.net

Commit message

Show changelogs for click package updates

Description of the change

I'm proposing this so that I can get some reviews / help.

First cut at showing click package changelogs

Some issues

  - Icon moves down when you expand it - any standard way to anchor it or do we need to place it manually?
  - Using this custom implementation of expanding feels weird
  - Eliding doesn't work
  - Are you always guaranteed to have a changelog?

Can you help me with these issues? 2 and 4 might not matter but the others do I think.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:709
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/834/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/390
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/336
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-amd64-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/26
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-armhf-ci/26/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/26
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/860
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/763
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/763/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/7474
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/299
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/436
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/436/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/834/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Sebastien Bacher (seb128) wrote :

Testing that on a desktop (with some tweaks and custom text for the changelog) I don't see the moving icon issue nor the eliding one. What do you mean "eliding doesn"t work", are we speaking about horizontal ellipsizing?

Do you know why we need a custom widget there?

Not sure about the changelog question...

Reply

Unmerged revisions

709. By Iain Lane

First cut at showing click package changelogs

Some issues

  - Icon moves down when you expand it
  - Using this custom implementation of expanding feels weird
  - Eliding doesn't work
  - Are you always guaranteed to have a changelog?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches