Merge lp://qastaging/~laney/ubuntu-system-settings/private-module-directory into lp://qastaging/ubuntu-system-settings

Proposed by Iain Lane
Status: Merged
Approved by: Ken VanDine
Approved revision: 98
Merged at revision: 96
Proposed branch: lp://qastaging/~laney/ubuntu-system-settings/private-module-directory
Merge into: lp://qastaging/ubuntu-system-settings
Diff against target: 57 lines (+6/-2)
5 files modified
common-project-config.pri (+2/-0)
debian/ubuntu-system-settings.install (+1/-1)
plugins/background/background.pro (+1/-1)
src/main.cpp (+1/-0)
src/system-settings.pro (+1/-0)
To merge this branch: bzr merge lp://qastaging/~laney/ubuntu-system-settings/private-module-directory
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ken VanDine Approve
Review via email: mp+172880@code.qastaging.launchpad.net

Commit message

Install the private library(ies) into /usr/lib/$DEB_HOST_MULTIARCH/ubuntu-system-settings and add this to the import path. This means that the modules aren't exposed to the public.

Description of the change

Install the private library(ies) into /usr/lib/$DEB_HOST_MULTIARCH/ubuntu-system-settings and add this to the import path. This means that the modules aren't exposed to the public.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote :

Awesome, thanks!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:98
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~laney/ubuntu-system-settings/private-module-directory/+merge/172880/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/57/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-saucy-amd64-ci/57

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-system-settings-ci/57/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches