Merge lp://qastaging/~laney/unity-lens-music/small-leak-fix into lp://qastaging/unity-lens-music
Proposed by
Iain Lane
| Status: | Merged |
|---|---|
| Approved by: | Michal Hruby |
| Approved revision: | 128 |
| Merged at revision: | 127 |
| Proposed branch: | lp://qastaging/~laney/unity-lens-music/small-leak-fix |
| Merge into: | lp://qastaging/unity-lens-music |
| Diff against target: |
269 lines (+42/-42) 2 files modified
src/banshee-collection.vala (+38/-38) src/rhythmbox-collection.vala (+4/-4) |
| To merge this branch: | bzr merge lp://qastaging/~laney/unity-lens-music/small-leak-fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit message
Transfer ownership of iterator in the Rhythmbox track_info_ready callback to avoid copies.
Description of the change
I'm not sure I completely understand reference counting in Vala yet, but this fix seems to allow the iter to be freed later on, saving a small amount of memory (~350kB-ish) when the daemon is being used with a large-ish collection.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Copying Dee's ModelIters is a noop (basically: "void *a, *b; a = b;"), so this can't possibly have any impact on memory consumption.
That being said, I'm approving this to get at least those whitespace fixes in, so it doesn't "taint" further MPs.