Libertine

Merge lp://qastaging/~larryprice/libertine/libertine-shell-ssh into lp://qastaging/libertine

libertine-shell-ssh
Merge into devel

Proposed by Larry Price on 2017-03-08

Status:

Merged

Approved by:

Christopher Townsend on 2017-04-07

Approved revision:

423

Merged at revision:

459

Proposed branch:

lp://qastaging/~larryprice/libertine/libertine-shell-ssh

Merge into:

lp://qastaging/libertine

Diff against target:

373 lines (+337/-3)

5 files modified

debian/libertine-tools.install (+3/-0)
tools/CMakeLists.txt (+3/-3)
tools/completions/libertine-shell (+50/-0)
tools/libertine-shell (+255/-0)
tools/libertine-shell.1 (+26/-0)

To merge this branch:

bzr merge lp://qastaging/~larryprice/libertine/libertine-shell-ssh

Wishlist

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Christopher Townsend (community)		2017-03-08	Approve on 2017-04-07
Libertine CI Bot	continuous-integration		Approve on 2017-04-06
Review via email: mp+319369@code.qastaging.launchpad.net

Commit message

Add tool to easily ssh into libertine containers.

Description of the change

Add tool to easily ssh into libertine containers.

Revision history for this message

Libertine CI Bot (libertine-ci-bot) wrote on 2017-03-08:

FAILED: Continuous integration, rev:416
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/452/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/libertine/job/build/837/console
    SUCCESS: https://jenkins.canonical.com/libertine/job/build-0-fetch/847
    FAILURE: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=xenial+overlay/839/console
    FAILURE: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=amd64,release=zesty/839/console
    FAILURE: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=xenial+overlay/839/console
    FAILURE: https://jenkins.canonical.com/libertine/job/build-2-binpkg/arch=i386,release=zesty/839/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/452/rebuild

review: Needs Fixing (continuous-integration)

lp://qastaging/~larryprice/libertine/libertine-shell-ssh updated on 2017-03-08

417. By Larry Price on 2017-03-08: how did i forget to add libertine-shell to install...

Revision history for this message

Libertine CI Bot (libertine-ci-bot) wrote on 2017-03-08:

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/453/rebuild

review: Approve (continuous-integration)

lp://qastaging/~larryprice/libertine/libertine-shell-ssh updated on 2017-03-09

418. By Larry Price on 2017-03-09: prevent non-lx* containers from using libertine-shell
419. By Larry Price on 2017-03-09: merge

Revision history for this message

Libertine CI Bot (libertine-ci-bot) wrote on 2017-03-09:

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/457/rebuild

review: Approve (continuous-integration)

lp://qastaging/~larryprice/libertine/libertine-shell-ssh updated on 2017-04-05

420. By Larry Price on 2017-04-05: merge

Revision history for this message

Libertine CI Bot (libertine-ci-bot) wrote on 2017-04-05:

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/509/rebuild

review: Approve (continuous-integration)

Revision history for this message

Christopher Townsend (townsend) wrote on 2017-04-05:

I built the packages, installed them, and rebooted the system. I then logged in to U8, and this is what I get when running libertine-shell:

$ libertine-shell -i test-lxd
Traceback (most recent call last):
  File "/usr/bin/libertine-shell", line 248, in <module>
    main()
  File "/usr/bin/libertine-shell", line 216, in main
    with open(os.path.join(utils.get_libertine_container_home_dir(config.container_id), "libertine-shell-found-ip")) as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/townsend/.local/share/libertine-container/user-data/test-lxd/libertine-shell-found-ip'

review: Needs Fixing

lp://qastaging/~larryprice/libertine/libertine-shell-ssh updated on 2017-04-05

421. By Larry Price on 2017-04-05: use bind mounted dir if necessary

Revision history for this message

Libertine CI Bot (libertine-ci-bot) wrote on 2017-04-05:

Click here to trigger a rebuild:
https://jenkins.canonical.com/libertine/job/lp-libertine-ci/510/rebuild

review: Approve (continuous-integration)

Revision history for this message

Christopher Townsend (townsend) wrote on 2017-04-06:

Ok, next issue:)

I'm trying this on a machine that I have never used ssh on. I get the following error:

$ libertine-shell -i test-lxd
Traceback (most recent call last):
  File "/usr/bin/libertine-shell", line 254, in <module>
    main()
  File "/usr/bin/libertine-shell", line 229, in main
    config.setup_public_keys(hostname)
  File "/usr/bin/libertine-shell", line 83, in setup_public_keys
    all_lines, host_line = self._ssh_config_lines(hostname)
  File "/usr/bin/libertine-shell", line 148, in _ssh_config_lines
    with open(config_path, 'r') as f:
FileNotFoundError: [Errno 2] No such file or directory: '/home/townsend/.ssh/config'