AppMenu GTK+

Merge lp://qastaging/~larsu/appmenu-gtk/lp1026160 into lp://qastaging/appmenu-gtk/12.10

  1. lp1026160
  2. Merge into trunk.12.10
Proposed by Lars Karlitski
Status: Merged
Approved by: Charles Kerr
Approved revision: 153
Merged at revision: 153
Proposed branch: lp://qastaging/~larsu/appmenu-gtk/lp1026160
Merge into: lp://qastaging/appmenu-gtk/12.10
Diff against target: 17 lines (+5/-3)
1 file modified
src/bridge.c (+5/-3)
To merge this branch: bzr merge lp://qastaging/~larsu/appmenu-gtk/lp1026160
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
jenkins (community) continuous-integration Approve
Review via email: mp+115587@code.qastaging.launchpad.net

Commit message

Check for NULL before using GtkMenu.attach-widget

This wasn't a problem before, because GtkMenu didn't notify when it was
detached from its parent widget. This was fixed in gtk with f81bd6c.

To post a comment you must log in.
Revision history for this message
jenkins (martin-mrazik+qa) wrote :

FAILED: Continuous integration, rev:153
http://s-jenkins:8080/job/appmenu-gtk-ci/2/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/appmenu-gtk-ci/./label=precise-clean-amd64/2/console
    SUCCESS: http://s-jenkins:8080/job/appmenu-gtk-ci/./label=precise-clean-i386/2/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Martin Mrazik (mrazik) wrote :

The jenkins failure above is my bad. Should be fixed now.

Revision history for this message
jenkins (martin-mrazik+qa) wrote :

PASSED: Continuous integration, rev:153
http://s-jenkins:8080/job/appmenu-gtk-ci/3/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/appmenu-gtk-ci/./label=precise-clean-amd64/3/console
    SUCCESS: http://s-jenkins:8080/job/appmenu-gtk-ci/./label=precise-clean-i386/3/console

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches