Indicator Display Objects

Merge lp://qastaging/~larsu/ido/lp1229076 into lp://qastaging/ido/13.10

lp1229076
Merge into trunk.13.10

Proposed by Lars Karlitski on 2013-09-24

Status:

Merged

Approved by:

Ted Gould on 2013-09-25

Approved revision:

149

Merged at revision:

149

Proposed branch:

lp://qastaging/~larsu/ido/lp1229076

Merge into:

lp://qastaging/ido/13.10

Diff against target:

141 lines (+59/-9)

1 file modified

src/idoscalemenuitem.c (+59/-9)

To merge this branch:

bzr merge lp://qastaging/~larsu/ido/lp1229076

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ted Gould (community)		2013-09-24	Approve on 2013-09-25
PS Jenkins bot (community)	continuous-integration		Approve on 2013-09-24
Review via email: mp+187378@code.qastaging.launchpad.net

Description of the change

idoscalemenuitem: don't update the action state when the action state changes

GtkRange has the same weird semantics for its "value-changed" signal that the check menu items have: it is emitted not only on user interaction, but also when gtk_range_set_value() is called.

The handler to "value-changed" updates the action. gtk_range_set_value() is called when the action notifies about a state change. Loop, meet loop.

This patch works around that by adding a "value-changed" to IdoScaleMenuItem that is only emitted when the user changes the slider's value.

Revision history for this message