Indicator Display Objects

Merge lp://qastaging/~larsu/ido/revert-slider into lp://qastaging/ido/13.10

  1. revert-slider
  2. Merge into trunk.13.10
Proposed by Lars Karlitski
Status: Merged
Approved by: Ted Gould
Approved revision: 147
Merged at revision: 147
Proposed branch: lp://qastaging/~larsu/ido/revert-slider
Merge into: lp://qastaging/ido/13.10
Diff against target: 22 lines (+4/-1)
1 file modified
src/idoscalemenuitem.c (+4/-1)
To merge this branch: bzr merge lp://qastaging/~larsu/ido/revert-slider
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+185680@code.qastaging.launchpad.net

Commit message

Reverse slider movement when scrolling by default

Description of the change

Revert slider movement when scrolling by default

This makes scroll direction for sliders in ido behave more like the expectation of most users (anecdotally), like it does for the sound indicator itself, and like the sliders in the sound panel.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:147
http://jenkins.qa.ubuntu.com/job/ido-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-saucy-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ido-saucy-armhf-ci/17
        deb: http://jenkins.qa.ubuntu.com/job/ido-saucy-armhf-ci/17/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ido-ci/35/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

Works. My argument would be that you should be able to use the scroll wheel the same on the slider as the icon. This makes them match up, which seems logical.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches