Indicator Date and Time

Merge lp://qastaging/~larsu/indicator-datetime/dont-use-gdbusproxy into lp://qastaging/indicator-datetime/15.10

  1. dont-use-gdbusproxy
  2. Merge into trunk.15.10
Proposed by Lars Karlitski
Status: Rejected
Rejected by: Charles Kerr
Proposed branch: lp://qastaging/~larsu/indicator-datetime/dont-use-gdbusproxy
Merge into: lp://qastaging/indicator-datetime/15.10
Prerequisite: lp://qastaging/~laney/indicator-datetime/timedated-timezone-property
Diff against target: 184 lines (+35/-107)
1 file modified
src/timezone-timedated.cpp (+35/-107)
To merge this branch: bzr merge lp://qastaging/~larsu/indicator-datetime/dont-use-gdbusproxy
Reviewer Review Type Date Requested Status
Charles Kerr (community) Needs Resubmitting
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+270081@code.qastaging.launchpad.net

Commit message

Use timedated's Timezone property to find out the current timezone and learn about changes to it

Description of the change

Use timedated's Timezone property to find out the current timezone and learn about changes to it

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:426
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/331/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/21/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/331/rebuild

review: Approve (continuous-integration)
Revision history for this message
Charles Kerr (charlesk) wrote :

Oh, this is quite nice. Thank you!

review: Approve
Revision history for this message
Charles Kerr (charlesk) wrote :

superceded by https://code.launchpad.net/~larsu/indicator-datetime/remove-test-warnings/+merge/270076, which landed on 2015-09-09

review: Needs Resubmitting

Unmerged revisions

426. By Lars Karlitski

timezone-timedated: subscribe to PropertiesChanged directly

This avoids some unnecessary calls that GDBusProxy makes and the name
watching.

425. By Iain Lane

Make test-live-actions quit itself once the tz has been changed, the mock no longer does this

424. By Iain Lane

Avoid nested GMainLoops by reading from the file on startup

Restore some tests for this functionality.

423. By Iain Lane

Add some comments

422. By Iain Lane

Rename FileTimezone to TimedatedTimezone

421. By Iain Lane

Add a timeout so we can't hang forever

420. By Iain Lane

Use timedated's Timezone property instead of watching /etc/timezone

Still need to rename everything to not use "timezone-file"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches