Indicator Date and Time

Merge lp://qastaging/~larsu/indicator-datetime/lp1061867 into lp://qastaging/indicator-datetime/12.10

lp1061867
Merge into trunk.12.10

Proposed by Lars Karlitski on 2012-10-05

Status:	Merged
Approved by:	Charles Kerr on 2012-10-24
Approved revision:	189
Merged at revision:	189
Proposed branch:	lp://qastaging/~larsu/indicator-datetime/lp1061867
Merge into:	lp://qastaging/indicator-datetime/12.10
Diff against target:	16 lines (+6/-0) 1 file modified src/datetime-service.c (+6/-0)
To merge this branch:	bzr merge lp://qastaging/~larsu/indicator-datetime/lp1061867
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2012-10-15
jenkins (community)	continuous-integration		Needs Fixing on 2012-10-05
Charles Kerr (community)		2012-10-05	Approve on 2012-10-05
Mathieu Trudel-Lapierre		2012-10-05	Approve on 2012-10-05
Review via email: mp+128248@code.qastaging.launchpad.net

Description of the change

I cannot reproduce bug #1061867, but it seems this missing NULL check is the issue.

e_cal_client_new's documentation isn't very helpful: it takes a GError but doesn't state whether the returned value might be NULL.

Revision history for this message

jenkins (martin-mrazik+qa) wrote on 2012-10-05:

PASSED: Continuous integration, rev:189
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/12/
Executed test runs:
SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=quantal,flavor=amd64/12/console
SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/./build=pbuilder,distribution=quantal,flavor=i386/12/console

review: Approve (continuous-integration)

Revision history for this message

Mathieu Trudel-Lapierre (cyphermox) wrote on 2012-10-05:

Looks fine, there's a few cases where the function above can return NULL (without an error), namely if the source is invalid or if it's the wrong type, and it's very likely that the appointment sources might in fact be of type other than ..._EVENT if people have complex calendars (memos, tasks).

review: Approve

Revision history for this message

Charles Kerr (charlesk) wrote on 2012-10-05:

I'm not able to trigger this crash, but looking at the report and reading this code, I agree with Lars' reasoning.

review: Approve

Revision history for this message

jenkins (martin-mrazik+qa) wrote on 2012-10-05:

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/indicator-datetime-autolanding/8/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/8/console
FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/8/console