Indicator Date and Time

Merge lp://qastaging/~larsu/indicator-datetime/remove-test-warnings into lp://qastaging/indicator-datetime/15.10

  1. remove-test-warnings
  2. Merge into trunk.15.10
Proposed by Lars Karlitski
Status: Superseded
Proposed branch: lp://qastaging/~larsu/indicator-datetime/remove-test-warnings
Merge into: lp://qastaging/indicator-datetime/15.10
Prerequisite: lp://qastaging/~laney/indicator-datetime/timedated-timezone-property
Diff against target: 125 lines (+13/-44)
4 files modified
tests/CMakeLists.txt (+1/-0)
tests/glib-fixture.h (+9/-41)
tests/test-timezone-file.cpp (+2/-2)
tests/test-utils.cpp (+1/-1)
To merge this branch: bzr merge lp://qastaging/~larsu/indicator-datetime/remove-test-warnings
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Indicator Applet Developers Pending
Review via email: mp+270067@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2015-09-03.

This proposal has been superseded by a proposal from 2015-09-03.

Description of the change

Remove warnings from test logs

Swallow the ones that are expected and fail the test if they don't show up. In addition, fail tests if unexpected warnings show up again.

Also remove some dead code that dealt with counting log emissions.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:421
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/328/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/18/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/328/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:427
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/329/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/19/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/329/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~larsu/indicator-datetime/remove-test-warnings updated
426. By Lars Karlitski

timezone-timedated: subscribe to PropertiesChanged directly

This avoids some unnecessary calls that GDBusProxy makes and the name
watching.

427. By Lars Karlitski

test-utils: don't pass NULL as gsettings string value

NULL is not a valid string. Use the empty string instead.

428. By Lars Karlitski

glib-fixture: fail tests on unexpected warnings

This requires specifying which warnings are expected to be thrown (only
test-timezone-file needed this for now).

However, only fail on warnings in the Indicator-Datetime log domain so
that we don't fail on gstreamer (or other library) warnings for now.

429. By Lars Karlitski

state-fixture: use TestDBusFixture for system bus

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches