Merge lp://qastaging/~larsu/indicator-messages/add-simple-dbus-api into lp://qastaging/indicator-messages/13.10
Status: | Work in progress |
---|---|
Proposed branch: | lp://qastaging/~larsu/indicator-messages/add-simple-dbus-api |
Merge into: | lp://qastaging/indicator-messages/13.10 |
Diff against target: |
545 lines (+407/-20) 7 files modified
m4/gcov.m4 (+1/-1) src/Makefile.am (+3/-1) src/im-application-list.c (+108/-18) src/im-application-list.h (+9/-0) src/im-notifications.c (+241/-0) src/im-notifications.h (+40/-0) src/messages-service.c (+5/-0) |
To merge this branch: | bzr merge lp://qastaging/~larsu/indicator-messages/add-simple-dbus-api |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Disapprove | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+224622@code.qastaging.launchpad.net |
Commit message
Add com.canonical.
That API is geared towards a more traditional notification center rather than the messaging menu as known on the desktop. It can thus be much simpler.
It primarily benefits services that send messages on behalf of applications.
Description of the change
This is a proposal for a new API for the messaging menu.
libmessaging-menu is hard to use from go (main loop and all) and fairly inefficient for services that want to send messages on behalf of many applications. This new API is dbus-only and trimmed down to only support the notification center style of the messaging menu that we have on the phone. I assume we'll get the same on the desktop at some point.
Going forward, I suggest that unity8 exposes this API itself and uses it for both the messaging menu and notifications. That's why I called it com.canonical.
- AddNotification(s app_id, s notification_id, a{sv} notification) adds a notification/
- RemoveNotificat
- The signal NotificationAct
Unfortunately, unity8 currently only supports very few action configurations in the messaging menu. It should probably just use the same components as it uses for notifications.
We did something similar in GNOME a while back. We could join forces and move a new spec to freedesktop to replace the current org.freedesktop
Unmerged revisions
- 417. By Lars Karlitski
-
m4/gcov.m4: add lcov version 1.11
- 416. By Lars Karlitski
-
Remove passive aggressive comment about g_dbus_
connection_ register_ object( ) It's incorrect: register_object() does take a ref on the interface info. The
unref is unnecessary because g_dbus_node_info_ lookup_ interface( ) doesn't return
a ref. - 415. By Lars Karlitski
-
Add com.canonical.
Notifications dbus API That API is geared towards a more traditional notification center rather than
the messaging menu as known on the desktop. It can thus be much simpler.It primarily benefits services that send messages on behalf of applications.
FAILED: Continuous integration, rev:415 jenkins. qa.ubuntu. com/job/ indicator- messages- ci/122/ jenkins. qa.ubuntu. com/job/ indicator- messages- utopic- amd64-ci/ 2/console jenkins. qa.ubuntu. com/job/ indicator- messages- utopic- armhf-ci/ 2/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/indicator- messages- ci/122/ rebuild
http://