libindicator

Merge lp://qastaging/~larsu/libindicator/call-ido-init into lp://qastaging/libindicator/13.10

  1. call-ido-init
  2. Merge into trunk.13.10
Proposed by Lars Karlitski
Status: Merged
Merge reported by: Lars Karlitski
Merged at revision: not available
Proposed branch: lp://qastaging/~larsu/libindicator/call-ido-init
Merge into: lp://qastaging/libindicator/13.10
Diff against target: 52 lines (+6/-1)
3 files modified
configure.ac (+3/-1)
debian/control (+1/-0)
tools/indicator-loader.c (+2/-0)
To merge this branch: bzr merge lp://qastaging/~larsu/libindicator/call-ido-init
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Ted Gould (community) Approve
Review via email: mp+165502@code.qastaging.launchpad.net

Description of the change

Call ido_init() in indicator-loader.

So that it registers IdoMenuItemFactory with gtk+ and the custom menu items are available in the loader.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:490
http://jenkins.qa.ubuntu.com/job/libindicator-ci/16/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/2/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/16/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:491
http://jenkins.qa.ubuntu.com/job/libindicator-ci/18/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/18/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

This depends on a new version of ido (hence the CI failure). It's in lp:~larsu/ido/custom-menu-items.

Revision history for this message
Ted Gould (ted) wrote :

The IDO version required needs to be in the /debian/control files as well.

review: Needs Fixing
Revision history for this message
Lars Karlitski (larsu) wrote :

> The IDO version required needs to be in the /debian/control files as well.

Thanks, fixed in r492.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:492
http://jenkins.qa.ubuntu.com/job/libindicator-ci/20/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/6/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/20/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/libindicator-autolanding/8/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-autolanding/6/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-autolanding/6/console

review: Needs Fixing (continuous-integration)
lp://qastaging/~larsu/libindicator/call-ido-init updated
493. By Lars Karlitski

Revert r490

It's already applied on trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:493
http://jenkins.qa.ubuntu.com/job/libindicator-ci/25/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/12/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/11/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/25/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches