Merge lp://qastaging/~larsu/libindicator/entry-visibility-fix into lp://qastaging/libindicator/0.5

Proposed by Lars Karlitski
Status: Merged
Merge reported by: Lars Karlitski
Merged at revision: not available
Proposed branch: lp://qastaging/~larsu/libindicator/entry-visibility-fix
Merge into: lp://qastaging/libindicator/0.5
Diff against target: 44 lines (+8/-17)
1 file modified
libindicator/indicator-object.c (+8/-17)
To merge this branch: bzr merge lp://qastaging/~larsu/libindicator/entry-visibility-fix
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Indicator Applet Developers Pending
Review via email: mp+92666@code.qastaging.launchpad.net

Description of the change

See commit message of r447.

Noticed this while developing indicator-printers. It can be worked around by not calling indicator_object_set_visible (TRUE) when the indicator is already visible. But I think the correct place for the check is in libindicator.

To post a comment you must log in.
448. By Lars Karlitski

indicator_object_set_visible: no need to check for ENTRY_INIT

449. By Lars Karlitski

indicator_object_dispose: use _set_visible instead of reimplementing it

450. By Lars Karlitski

indicator_object_dispose: remove unneeded list of entries

Revision history for this message
Charles Kerr (charlesk) wrote :

larsu, thanks for the fast turnaround on the changes. 450 looks fine IMO

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches