libindicator

Merge lp://qastaging/~larsu/libindicator/root-action-dict-state into lp://qastaging/libindicator/13.10

  1. root-action-dict-state
  2. Merge into trunk.13.10
Proposed by Lars Karlitski
Status: Merged
Merged at revision: 484
Proposed branch: lp://qastaging/~larsu/libindicator/root-action-dict-state
Merge into: lp://qastaging/libindicator/13.10
Diff against target: 66 lines (+23/-12)
2 files modified
libindicator/indicator-ng.c (+20/-11)
tests/indicator-test-service.c (+3/-1)
To merge this branch: bzr merge lp://qastaging/~larsu/libindicator/root-action-dict-state
Reviewer Review Type Date Requested Status
Charles Kerr (community) Approve
Mathieu Trudel-Lapierre Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+154501@code.qastaging.launchpad.net

Description of the change

indicator-ng: allow a dictionary as the root action's state

This patch was already approved, but reverted on the 13.04 branch. Resubmitting for 13.10.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:481
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~larsu/libindicator/root-action-dict-state/+merge/154501/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/libindicator-ci/31/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-ci/./build=pbuilder,distribution=raring,flavor=armhf/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/31
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/libindicator-ci/./build=pbuilder,distribution=coverity-raring,flavor=amd64/31/artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/libindicator-ci/./build=pbuilder,distribution=raring,flavor=armhf/31/artifact/results/coverity/NO_COVERITY_DEFECTS.txt
    http://jenkins.qa.ubuntu.com/job/libindicator-ci/./build=pbuilder,distribution=raring,flavor=i386/31/artifact/results/coverity/NO_COVERITY_DEFECTS.txt

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/31/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Something's broken here, there's no diff... I would approve it, but I'd like to look at the diff anyway ;)

review: Needs Fixing
lp://qastaging/~larsu/libindicator/root-action-dict-state updated
483. By Lars Karlitski

indicator-ng: allow a dictionary as the root action's state

Hopefully, this is more straightforward to use than (sssb). It's also
extensible.

(sssb) is still supported for backwards compatibility, but I wouldn't recommend
using it anymore.

Revision history for this message
Lars Karlitski (larsu) wrote :

Ah, I simply pushed the same branch again, which was already merged (and then later superseded by your revert). Applied it on top of trunk again.

Revision history for this message
Charles Kerr (charlesk) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches