lp://qastaging/~larsu/notify-osd/1520667

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://qastaging/notify-osd at revision 502

Sebastien Bacher: Approve on 2015-12-01

Diff: 48 lines (+11/-3)

2 files modified

src/bubble.c (+10/-2)
tests/Makefile.am (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1520667: Try to load images from the icon theme

High

Fix Released

Link a bug report

Related blueprints

504. By Lars Karlitski on 2015-12-01

tests: use absolute icon paths

503. By Lars Karlitski on 2015-11-27

bubble_set_icon: also allow paths in icon name field

This is against the spec, which only allows file:// uris and icon names,
but is used by many applications and was supported in earlier versions
of notify-osd.

502. By Lars Karlitski on 2015-11-27

bubble_set_icon: use g_warning for errors

Using standard logging makes it easier to debug notify-osd using
G_DEBUG_MESSAGES and the like.

Also, the strings were missing newlines, which made errors hard to read.

501. By CI Train Bot Account on 2015-11-18

Releasing 0.9.35+16.04.20151118-0ubuntu1

500. By Lars Karlitski on 2015-11-18

Ignore body for synchronous notifications

It doesn't make sense to not show the notification at all when a body is set. Instead, simply ignore the body.

499. By CI Train Bot Account on 2015-11-12

Releasing 0.9.35+16.04.20151112-0ubuntu1

498. By Lars Karlitski on 2015-11-12

Listen to xsettings dpi changes

We only listened to font scale factor changes on gsettings, but retrieved the actual value from xsettings (through gtk-xft-dpi). This is racy: unity-settings-daemon also listens to gsettings and might not have set the xsettings value when our handler is run.

Fix this by listening to xsettings changes as well.

This means that we're now listening for both xsettings and gsettings changes for what is essentially the same thing and recalculate size on each of them. This creates some unnecessary work, but those settings are not changed very often. We can't only listen on xsettings, because there are other gsettings keys that might trigger a change in notification bubble appearance. Fixes: #1303796
Approved by: Sebastien Bacher

497. By Lars Karlitski on 2015-11-12

Refactor bubble_set_icon()

This function did the same as bubble_set_icon_for_path(), because paths are allowed in addition to icon names for both the app-icon parameter and the image-path hint.

Remove one of those functions and inline load_icon(), which gives us more control over when icon-not-found warnings are shown. Don't show one when using the fallback of prefixing the icon name with "notification-".

Remove TEMPORARY_ICON_PREFIX_WORKAROUND. It's been there since 2009 and
was never set to anything but 1.

496. By CI Train Bot Account on 2015-10-14

Releasing 0.9.35+15.10.20151014-0ubuntu1

495. By Iain Lane on 2015-10-14

Don't run test_dnd_screensaver - we can't dbus activate gnome-session and it's not practical to run a full session in autopkgtest currently

Approved by: Sebastien Bacher