Merge lp://qastaging/~larsu/notify-osd/fix-1189281 into lp://qastaging/notify-osd

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 466
Merged at revision: 466
Proposed branch: lp://qastaging/~larsu/notify-osd/fix-1189281
Merge into: lp://qastaging/notify-osd
Diff against target: 74 lines (+12/-6)
2 files modified
src/display.c (+6/-3)
src/stack.c (+6/-3)
To merge this branch: bzr merge lp://qastaging/~larsu/notify-osd/fix-1189281
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Mirco Müller (community) Approve
Sebastien Bacher Pending
Review via email: mp+168550@code.qastaging.launchpad.net

Commit message

Don't crash when an application is fullscreen when a notification arrives.

Description of the change

Don't crash when an application is fullscreen when a notification arrives.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:466
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~larsu/notify-osd/fix-1189281/+merge/168550/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/notify-osd-ci/2/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-armhf-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-i386-ci/1
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10932.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10933.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10934.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10935.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10936.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10937.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10938.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10939.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10940.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_10941.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_13648.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/31/artifact/results/coverity/CID_13649.html

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notify-osd-ci/2/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Mirco Müller (macslow) wrote :

Looks ok.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/notify-osd-autolanding/6/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-amd64-autolanding/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-armhf-autolanding/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-i386-autolanding/1
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10932.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10933.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10934.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10935.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10936.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10937.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10938.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10939.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10940.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_10941.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_13648.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/33/artifact/results/coverity/CID_13649.html

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:466
http://jenkins.qa.ubuntu.com/job/notify-osd-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-amd64-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-armhf-ci/2
    SUCCESS: http://jenkins.qa.ubuntu.com/job/notify-osd-saucy-i386-ci/2
Coverity artifacts:
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10932.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10933.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10934.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10935.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10936.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10937.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10938.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10939.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10940.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_10941.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_13648.html
    http://jenkins.qa.ubuntu.com/job/generic-coverity-check/32/artifact/results/coverity/CID_13649.html

Click here to trigger a rebuild:
http://s-jenkins:8080/job/notify-osd-ci/3/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches