Merge lp://qastaging/~larsu/notify-osd/ignore-body-for-sync-bubbles into lp://qastaging/notify-osd

Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 497
Merged at revision: 500
Proposed branch: lp://qastaging/~larsu/notify-osd/ignore-body-for-sync-bubbles
Merge into: lp://qastaging/notify-osd
Diff against target: 11 lines (+0/-1)
1 file modified
src/bubble.c (+0/-1)
To merge this branch: bzr merge lp://qastaging/~larsu/notify-osd/ignore-body-for-sync-bubbles
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email: mp+277855@code.qastaging.launchpad.net

Commit message

Ignore body for synchronous notifications

It doesn't make sense to not show the notification at all when a body is set. Instead, simply ignore the body.

Description of the change

Ignore body for synchronous notifications

It doesn't make sense to not show the notification at all when a body is set. Instead, simply ignore the body.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me and fixes the issue, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches