Merge lp://qastaging/~larsu/notify-osd/spam-a-bit-less into lp://qastaging/notify-osd
Proposed by
Lars Karlitski
| Status: | Merged |
|---|---|
| Approved by: | Sebastien Bacher |
| Approved revision: | 494 |
| Merged at revision: | 497 |
| Proposed branch: | lp://qastaging/~larsu/notify-osd/spam-a-bit-less |
| Merge into: | lp://qastaging/notify-osd |
| Diff against target: |
314 lines (+71/-156) 3 files modified
src/bubble.c (+69/-150) src/bubble.h (+1/-5) src/stack.c (+1/-1) |
| To merge this branch: | bzr merge lp://qastaging/~larsu/notify-osd/spam-a-bit-less |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher | Approve | ||
|
Review via email:
|
|||
Commit message
Refactor bubble_set_icon()
This function did the same as bubble_
Remove one of those functions and inline load_icon(), which gives us more control over when icon-not-found warnings are shown. Don't show one when using the fallback of prefixing the icon name with "notification-".
Remove TEMPORARY_
was never set to anything but 1.
Description of the change
Refactor bubble_set_icon() a bit to remove warnings about not found icons when using the "notification-" fallback.
To post a comment you must log in.
Revision history for this message
| Lars Karlitski (larsu) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
looks fine and start of a new cycle is a good time to land such changes ;-)