Software Properties

Merge lp://qastaging/~larsu/software-properties/fix-wide-dialog into lp://qastaging/software-properties

  1. fix-wide-dialog
  2. Merge into main
Proposed by Lars Karlitski
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 918
Merged at revision: 919
Proposed branch: lp://qastaging/~larsu/software-properties/fix-wide-dialog
Merge into: lp://qastaging/software-properties
Diff against target: 11 lines (+1/-0)
1 file modified
data/gtkbuilder/dialog-cache-outofdate.ui (+1/-0)
To merge this branch: bzr merge lp://qastaging/~larsu/software-properties/fix-wide-dialog
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+238905@code.qastaging.launchpad.net

Commit message

dialog-cache-outofdate: make sure the label is wrapped at ~70 chars

Gtk doesn't limit windows to a maximum default size anymore, which lead to this dialog being very wide in some locales.

Description of the change

dialog-cache-outofdate: make sure the label is wrapped at ~70 chars

Gtk doesn't limit windows to a maximum default size anymore, which lead to this dialog being very wide in some locales.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Looks good, this should probably be SRUed into utopic, is there a open bug for this already?

review: Approve
Revision history for this message
Lars Karlitski (larsu) wrote :

There's no need to SRU it, we have a patch in gtk which limits window size again. We'll remove it for V to find the remaining issues.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: