Merge lp://qastaging/~laurynas-biveinis/percona-server/26611-bug1064333-5.1 into lp://qastaging/percona-server/5.1

Proposed by Laurynas Biveinis
Status: Merged
Approved by: Stewart Smith
Approved revision: no longer in the source branch.
Merged at revision: 499
Proposed branch: lp://qastaging/~laurynas-biveinis/percona-server/26611-bug1064333-5.1
Merge into: lp://qastaging/percona-server/5.1
Prerequisite: lp://qastaging/~laurynas-biveinis/percona-server/26611-bug917942-5.1
Diff against target: 289 lines (+137/-17)
4 files modified
Percona-Server/mysql-test/r/percona_innodb_fake_changes.result (+41/-1)
Percona-Server/mysql-test/t/percona_innodb_fake_changes.test (+66/-2)
Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc (+9/-3)
Percona-Server/storage/innodb_plugin/row/row0mysql.c (+21/-11)
To merge this branch: bzr merge lp://qastaging/~laurynas-biveinis/percona-server/26611-bug1064333-5.1
Reviewer Review Type Date Requested Status
Stewart Smith (community) Approve
Review via email: mp+130366@code.qastaging.launchpad.net

Description of the change

Fix bug 1064333 (Fake changes bump the changed row counters).

There are following issues with the stat acounting with fake changes:
- InnoDB handler methods write_row, update_row, delete_row update the
  userstat changed row counter unconditionally.
- row_insert_for_mysql(), row_update_for_mysql() and
  row_update_cascade_for_mysql() update the number of changed rows
  since last stat update, innodb_rows_inserted, innodb_rows_updated
  and innodb_rows_deleted unconditionally.

Fixed and extended the percona_innodb_fake_changes testcase to check
these stats for all the fixed cases.

http://jenkins.percona.com/job/percona-server-5.1-param/450/

26611

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches