Merge lp://qastaging/~lbssousa/lightdm/guest-account-union-mount-optimizations into lp://qastaging/lightdm

Proposed by Laércio de Sousa
Status: Merged
Merged at revision: 2216
Proposed branch: lp://qastaging/~lbssousa/lightdm/guest-account-union-mount-optimizations
Merge into: lp://qastaging/lightdm
Diff against target: 388 lines (+132/-139)
6 files modified
debian/guest-account.sh (+89/-139)
debian/guest-session-setup.sh (+34/-0)
debian/guest-session-startup.desktop (+5/-0)
debian/guest-session.profile (+1/-0)
debian/lightdm.install (+1/-0)
debian/rules (+2/-0)
To merge this branch: bzr merge lp://qastaging/~lbssousa/lightdm/guest-account-union-mount-optimizations
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+274553@code.qastaging.launchpad.net

Description of the change

This is my follow-up to union-mount scheme for guest-account creation. I've made several optimizations to reduce amount of "chown -R" calls and file/directory on-the-fly creations. Some parts of original guest-account script were moved to separate files.

This merge is a bit more complex than the previous one, since new files are about to be added for packaging. Please review with care!

To post a comment you must log in.
2209. By Laércio de Sousa

Make /usr/share/lightdm/guest-session/setup.sh executable on install.

Revision history for this message
Robert Ancell (robert-ancell) wrote :

I'd be lying if I said I knew all the details of this change but it looks good to me and I think you're the guest account expert!

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

That changes makes the guest session stop working on xenial, see bug #1515704 (and https://code.launchpad.net/~seb128/lightdm/xenial-guest-session/+merge/277371 for a suggested fix)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches