Merge lp://qastaging/~lderan/ubuntu-autopilot-tests/ubuntu-autopilot-tests into lp://qastaging/ubuntu-autopilot-tests
Proposed by
Thomas Molloy
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://qastaging/~lderan/ubuntu-autopilot-tests/ubuntu-autopilot-tests |
| Merge into: | lp://qastaging/ubuntu-autopilot-tests |
| Diff against target: |
1649 lines (+1350/-3) 52 files modified
xubuntu_autopilot_tests/abiword/__init__.py (+2/-0) xubuntu_autopilot_tests/abiword/test_abiword.py (+65/-0) xubuntu_autopilot_tests/catfish/__init__.py (+2/-0) xubuntu_autopilot_tests/catfish/test_catfish.py (+51/-0) xubuntu_autopilot_tests/evince/__init__.py (+2/-0) xubuntu_autopilot_tests/evince/test_evince.py (+51/-0) xubuntu_autopilot_tests/file-roller/__init__.py (+2/-0) xubuntu_autopilot_tests/file-roller/test_file_roller.py (+51/-0) xubuntu_autopilot_tests/gmusicbrowser/__init__.py (+2/-0) xubuntu_autopilot_tests/gmusicbrowser/test_gmusicbrowser.py (+51/-0) xubuntu_autopilot_tests/gnome-calculator/__init__.py (+2/-0) xubuntu_autopilot_tests/gnome-calculator/test_gnome_calculator.py (+51/-0) xubuntu_autopilot_tests/gnumeric/__init__.py (+2/-0) xubuntu_autopilot_tests/gnumeric/test_gnumeric.py (+51/-0) xubuntu_autopilot_tests/gthumb/__init__.py (+2/-0) xubuntu_autopilot_tests/gthumb/test_gthumb.py (+51/-0) xubuntu_autopilot_tests/gucharmap/__init__.py (+2/-0) xubuntu_autopilot_tests/gucharmap/test_gucharmap.py (+51/-0) xubuntu_autopilot_tests/mousepad/__init__.py (+2/-0) xubuntu_autopilot_tests/mousepad/test_mousepad.py (+51/-0) xubuntu_autopilot_tests/onboard/__init__.py (+2/-0) xubuntu_autopilot_tests/onboard/test_onboard.py (+51/-0) xubuntu_autopilot_tests/orage-calendar/__init__.py (+2/-0) xubuntu_autopilot_tests/orage-calendar/test_orage_calendar.py (+51/-0) xubuntu_autopilot_tests/orage-globaltime/__init__.py (+2/-0) xubuntu_autopilot_tests/orage-globaltime/test_orage_globaltime.py (+51/-0) xubuntu_autopilot_tests/pavucontrol/__init__.py (+2/-0) xubuntu_autopilot_tests/pavucontrol/test_pavucontrol.py (+51/-0) xubuntu_autopilot_tests/pidgin/__init__.py (+2/-0) xubuntu_autopilot_tests/pidgin/test_pidgin.py (+51/-0) xubuntu_autopilot_tests/ristretto/__init__.py (+2/-0) xubuntu_autopilot_tests/ristretto/test_ristretto.py (+51/-0) xubuntu_autopilot_tests/simple-scan/__init__.py (+2/-0) xubuntu_autopilot_tests/simple-scan/test_simple_scan.py (+50/-0) xubuntu_autopilot_tests/sudoku/__init__.py (+2/-0) xubuntu_autopilot_tests/sudoku/test_sudoku.py (+49/-0) xubuntu_autopilot_tests/thunderbird/__init__.py (+2/-0) xubuntu_autopilot_tests/thunderbird/test_thunderbird.py (+49/-0) xubuntu_autopilot_tests/transmission-gtk/__init__.py (+2/-0) xubuntu_autopilot_tests/transmission-gtk/test_transmission_gtk.py (+49/-0) xubuntu_autopilot_tests/xfce4-appfinder/__init__.py (+2/-0) xubuntu_autopilot_tests/xfce4-appfinder/test_xfce4_appfinder.py (+51/-0) xubuntu_autopilot_tests/xfce4-dict/__init__.py (+2/-0) xubuntu_autopilot_tests/xfce4-dict/test_xfce4_dict.py (+51/-0) xubuntu_autopilot_tests/xfce4-screenshooter/__init__.py (+2/-0) xubuntu_autopilot_tests/xfce4-screenshooter/test_xfce4_screenshooter.py (+51/-0) xubuntu_autopilot_tests/xfce4-settings-manager/__init__.py (+2/-0) xubuntu_autopilot_tests/xfce4-settings-manager/test_xfce4_settings_manager.py (+66/-0) xubuntu_autopilot_tests/xfce4-taskmanager/__init__.py (+2/-0) xubuntu_autopilot_tests/xfce4-taskmanager/test_xfce4_taskmanager.py (+51/-0) xubuntu_autopilot_tests/xfce4-terminal/__init__.py (+1/-1) xubuntu_autopilot_tests/xfce4-terminal/test_terminal.py (+2/-2) |
| To merge this branch: | bzr merge lp://qastaging/~lderan/ubuntu-autopilot-tests/ubuntu-autopilot-tests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Nicholas Skaggs (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Added simple tests for Sudoku and gThumb to the Xubuntu Autopilot tests
To post a comment you must log in.
Revision history for this message
| Thomas Molloy (lderan) wrote | # |
Revision history for this message
| Thomas Molloy (lderan) wrote | # |
Unmerged revisions
- 70. By Thomas Molloy
-
working tests, need to be individually merged and if possible improved before doing so
- 69. By Thomas Molloy
-
fixes for the xubuntu tests
- 68. By Thomas Molloy
-
Added Ristretto Image Viewer test to the Xubuntu test directory
- 67. By Thomas Molloy
-
gmusicbrowser simple test for Xubuntu
- 66. By Thomas Molloy
-
Added Simple-scan test to Xubuntu tests
- 65. By Thomas Molloy
-
Corrected the gThumb test text
- 64. By Thomas Molloy
-
Added simple tests for Sudoku and gThumb to the Xubuntu Autopilot tests
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for these tests! Glad to see you trying out autopilot. I'll leave a few quick comments.
You should change the author to be yourself in these tests :-)
In gmusicbrowser/
In the gmusicbrowser test;
I take it you want the window to be the only one?
windows = self.app.
self.assertTrue
This is ok, but note that mainWindow.title will never change as it's already set (well, the app could change it, but I don't think that's what we're looking for here :-) ) I'm not exactly sure you need the eventually here, but if so you should ensure you get the window as part of the lambda function.
mainWindow = windows[0]
self.assertThat
Reviewing several apps at once is a bit hard; ideally split these up in the future :-) Overall this is a great first start. It seems you can't get introspection to work for these apps is that correct? If so, I would still like to see a bit more of the application tested if at all possible. I know using process manager will severely limit you, but it's worthwhile to see how creative you can be. Ping me on IRC @ balloons anytime for help or further info. Looking forward to seeing your tweaks.