Ubuntu
upstart package

Merge lp://qastaging/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0-dev into lp://qastaging/ubuntu/vivid/upstart

  1. Vivid (15.04)
  2. rm-libjson0-dev
  3. Merge into vivid
Proposed by Lance Goodridge
Status: Needs review
Proposed branch: lp://qastaging/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0-dev
Merge into: lp://qastaging/ubuntu/vivid/upstart
Diff against target: 44 lines (+9/-3)
2 files modified
debian/changelog (+6/-0)
debian/control (+3/-3)
To merge this branch: bzr merge lp://qastaging/~ldgoodridge95/ubuntu/vivid/upstart/rm-libjson0-dev
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Needs Fixing
Review via email: mp+250522@code.qastaging.launchpad.net

Description of the change

Removed libjson0-dev from the Dependencies list

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Please rebase/resubmit this against lp:ubuntu/upstart (~ubuntu-branches/ubuntu/wily/upstart/wily).

Also, it seems to me like if you used libjson-c-dev in Build-Depends rather than libjson-c2, you could altogether remove libjson from binary Depends, since it will be added automatically via ${shlibs:Depends}.

review: Needs Fixing
Reply
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Closing as Rejected: there was a new merge request proposed to fix this.

review: Disapprove
Reply
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Of course I did this all wrong; this is the new merge. Still should remove any mention of libjson from the binary Depends though; as they will be added automatically.

review: Needs Fixing
Reply

Unmerged revisions

1607. By Lance Goodridge

Replaced libjson0-dev with libjson-c2 in Dependencies.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches