LAVA master image scripts

Merge lp://qastaging/~le-chi-thu/lava-master-image-scripts/fix-partition-name into lp://qastaging/lava-master-image-scripts

fix-partition-name
Merge into trunk

Proposed by Le Chi Thu on 2012-04-12

Status:	Merged
Merged at revision:	53
Proposed branch:	lp://qastaging/~le-chi-thu/lava-master-image-scripts/fix-partition-name
Merge into:	lp://qastaging/lava-master-image-scripts
Diff against target:	30 lines (+11/-4) 1 file modified contrib/lava-partition-disk (+11/-4)
To merge this branch:	bzr merge lp://qastaging/~le-chi-thu/lava-master-image-scripts/fix-partition-name
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Zygmunt Krynicki (community)		Approve on 2012-04-18
Le Chi Thu (community)		Needs Resubmitting on 2012-04-18
Spring Zhang (community)	2012-04-12	Needs Fixing on 2012-04-13
Review via email: mp+101752@code.qastaging.launchpad.net

Description of the change

Fixed partition name bug in contrib/lava-partition-disk script.

Revision history for this message

Spring Zhang (qzhang) wrote on 2012-04-13:

I really recommend we use all of them to support both USB and MMC devices: mmcblkXpY or sdXY

review: Needs Fixing

Revision history for this message

Spring Zhang (qzhang) wrote on 2012-04-13:

previous code should work well with USB disk

Revision history for this message

Zygmunt Krynicki (zyga) wrote on 2012-04-13:

Ah, good catch.

I'm not sure I can merge it though. It _could_ be merged if we moved this step to the first-boot script where it belongs (then we can assume all boards have a real mmc device). The other option is to support both 'p' (mmc devices) and no '' (usb adapters).

Thanks
ZK

review: Needs Fixing

lp://qastaging/~le-chi-thu/lava-master-image-scripts/fix-partition-name updated on 2012-04-18