Midori Web Browser

Merge lp://qastaging/~lemonboy/midori/midori-hsts into lp://qastaging/midori

  1. midori-hsts
  2. Merge into trunk
Proposed by The Lemon Man
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 7044
Merged at revision: 7074
Proposed branch: lp://qastaging/~lemonboy/midori/midori-hsts
Merge into: lp://qastaging/midori
Diff against target: 230 lines (+117/-49)
1 file modified
katze/midori-hsts.vala (+117/-49)
To merge this branch: bzr merge lp://qastaging/~lemonboy/midori/midori-hsts
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+274049@code.qastaging.launchpad.net

Commit message

Make HSTS handle subdomains

Description of the change

At the moment the plugin serializes the whole table every time it adds a new rule since there's no stable destructor at the moment.

To post a comment you must log in.
lp://qastaging/~lemonboy/midori/midori-hsts updated
7044. By The Lemon Man

Improvements for the HSTS plugin.

Revision history for this message
The Lemon Man (lemonboy) wrote :

After a quick look at how the Cookie jar is implemented in libsoup it seems to me that writing out the whole list every time isn't a bad idea.
On the other end we might just detach this SessionFeature before terminating the process, leaving the serialization to happen in the 'detach' callback.

Revision history for this message
Paweł Forysiuk (tuxator) wrote :

Looks sensible. Lets get it in so it can use some real life testing.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: