Ubuntu
golang-github-go-git-go-git package

Merge ~levihackerman-102/ubuntu/+source/golang-github-go-git-go-git:ubuntu/devel into ubuntu/+source/golang-github-go-git-go-git:ubuntu/devel

  1. Git
  2. lp:~levihackerman-102/ubuntu/+source/golang-github-go-git-go-git
  3. ubuntu/devel
  4. Merge into ubuntu/devel
Proposed by Anshul Singh
Status: Needs review
Proposed branch: ~levihackerman-102/ubuntu/+source/golang-github-go-git-go-git:ubuntu/devel
Merge into: ubuntu/+source/golang-github-go-git-go-git:ubuntu/devel
Diff against target: 37 lines (+8/-1)
3 files modified
debian/changelog (+5/-0)
debian/control (+2/-1)
debian/rules (+1/-0)
Reviewer Review Type Date Requested Status
Shengjing Zhu Pending
Review via email: mp+469907@code.qastaging.launchpad.net

Commit message

Make debian rules change to fix regression: Addresses the failing regression tests due to no_proxy environment variable

Description of the change

Addresses the failing regression tests due to no_proxy environment variable

To post a comment you must log in.
Revision history for this message
Anshul Singh (levihackerman-102) wrote :

https://launchpad.net/~levihackerman-102/+archive/ubuntu/go-toolchains/+builds?build_state=built package built successfully on my PPA

Reply
Revision history for this message
Anshul Singh (levihackerman-102) wrote :

* Results:
  - golang-github-go-git-go-git/5.11.0-3ubuntu1
    + ✅ golang-github-go-git-go-git on oracular for amd64 @ 23.07.24 06:33:40 Log 🗒
    + ✅ golang-github-go-git-go-git on oracular for arm64 @ 23.07.24 06:36:23 Log 🗒
    + ❌ golang-github-go-git-go-git on oracular for i386 @ 23.07.24 06:32:05 Log 🗒
      • 48s FAIL 🟥
    + ✅ golang-github-go-git-go-git on oracular for ppc64el @ 23.07.24 06:36:31 Log 🗒
    + ✅ golang-github-go-git-go-git on oracular for s390x @ 23.07.24 06:36:23 Log 🗒

These are the test results after running autopkgtest on my PPA. Failing i386 test is not a regression as it was also failing before.

Reply
Revision history for this message
Shengjing Zhu (zhsj) wrote :

+ The commit message could be more clear. like combining the MP's description. As well as the changelog message.
+ Please squash the two commits. or better, we usually put the real change in debian/rules in one commit. `update-maintainer` (the change in debian/control) in one commit. and finally the debian/changelog in one commit.

Reply
Revision history for this message
Shengjing Zhu (zhsj) wrote :

sponsored in debian. need to sync it to ubuntu.

could you run `requestsync golang-github-go-git-go-git` to ask for sync?

Reply

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches