Merge ~lgp171188/launchpad:fix-data-dir-typo-readme into launchpad:master

Proposed by Guruprasad
Status: Needs review
Proposed branch: ~lgp171188/launchpad:fix-data-dir-typo-readme
Merge into: launchpad:master
Diff against target: 28 lines (+5/-5)
1 file modified
charm/launchpad-codehosting/README.md (+5/-5)
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+454809@code.qastaging.launchpad.net

Commit message

charm/launchpad-codehosting: Fix typos in the README

The bzr repositories root directory was wrongly mentioned as
`/srv/launchpad/data/mirror` instead of `/srv/launchpad/data/mirrors`.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

This is an improvement, but I think the volume should just be mounted on `/srv/launchpad/data`, since that matches what's done in other charms. We probably need to make sure that the `mirrors` subdirectory exists with the right ownership/permissions after mounting the volume, since the charm won't immediately be rerun to recreate it.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: