Merge lp://qastaging/~lifeless/testtools/bug-812793 into lp://qastaging/~testtools-committers/testtools/trunk
Proposed by
Robert Collins
| Status: | Merged |
|---|---|
| Approved by: | Jonathan Lange |
| Approved revision: | 305 |
| Merged at revision: | 305 |
| Proposed branch: | lp://qastaging/~lifeless/testtools/bug-812793 |
| Merge into: | lp://qastaging/~testtools-committers/testtools/trunk |
| Diff against target: |
71 lines (+29/-4) 3 files modified
NEWS (+7/-0) testtools/testcase.py (+6/-3) testtools/tests/test_testcase.py (+16/-1) |
| To merge this branch: | bzr merge lp://qastaging/~lifeless/testtools/bug-812793 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonathan Lange | Approve | ||
|
Review via email:
|
|||
Description of the change
Minor tweak, should be self evident.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The code change is indeed self-evident and good. Thanks.
This might have unintended consequences. _details_to_str treats the 'traceback' detail specially, rendering it not so much as a detail but as a traditional test traceback. With this change, if a fixture has a detail named 'traceback', that will be rendered as the main error. This could be confusing to users.
On balance, I'm OK with this patch landing, but would be much happier if we could resolve (or at least document) that potential source of confusion.
(Note: I think the _details_to_str special casing of 'traceback' is a bit of a kludge and would be glad to see it go.)