Midori Web Browser

Merge lp://qastaging/~limeth/midori/midori-bug-768569 into lp://qastaging/midori

  1. midori-bug-768569
  2. Merge into trunk
Proposed by Limeth
Status: Needs review
Proposed branch: lp://qastaging/~limeth/midori/midori-bug-768569
Merge into: lp://qastaging/midori
Diff against target: 78 lines (+45/-5)
2 files modified
data/faq.html (+1/-1)
midori/midori-notebook.vala (+44/-4)
To merge this branch: bzr merge lp://qastaging/~limeth/midori/midori-bug-768569
Reviewer Review Type Date Requested Status
Cris Dywan Needs Fixing
Review via email: mp+273314@code.qastaging.launchpad.net

Description of the change

- Change "Show Tab Icon Only" to "Pin Tab" and "Show Tab Label" to "Unpin Tab";
- Move pinned tab after pinned tabs on the left, move unpinned tab out of pinned tabs to the right

Fixes: https://bugs.launchpad.net/midori/+bug/768569

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

The behavior is erratic, there's a 50/50 chance the tab size is reduced and it's at the left side. Also pinned tabs are never restored upon restart.

I think all updates should happen in tab_minimized because that also applies on restart, rather than in the UI-specific callback. But from a quick check that's not resolving the fundamental problem here.

review: Needs Fixing
Reply
Revision history for this message
Cris Dywan (kalikiana) wrote :

Incidentally I always imagined if we did this sort of thing it would be the most natural to put the pinned tabs in the left-side hbox, and not keep them as regular tabs. If you haven't considered that, it might make thinks easier.

Reply

Unmerged revisions

7044. By Limeth

Move pinned tab after pinned tabs on the left, move unpinned tab out of pinned tabs to the right

7043. By Limeth

Change "Show Tab Icon Only" to "Pin Tab" and "Show Tab Label" to "Unpin Tab"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: