Linaro Android Frontend

Merge lp://qastaging/~linaro-infrastructure/linaro-android-frontend/rearrange-tabs-changes into lp://qastaging/linaro-android-frontend

  1. rearrange-tabs-changes
  2. Merge into trunk
Proposed by Georgy Redkozubov
Status: Merged
Approved by: Milo Casagrande
Approved revision: 305
Merged at revision: 295
Proposed branch: lp://qastaging/~linaro-infrastructure/linaro-android-frontend/rearrange-tabs-changes
Merge into: lp://qastaging/linaro-android-frontend
Diff against target: 905 lines (+669/-109)
4 files modified
android_build/frontend/views.py (+6/-0)
android_build/templates/index.html (+315/-59)
group-fixture.json (+72/-0)
static/index.js (+276/-50)
To merge this branch: bzr merge lp://qastaging/~linaro-infrastructure/linaro-android-frontend/rearrange-tabs-changes
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Review via email: mp+141326@code.qastaging.launchpad.net

Description of the change

This branch rearranges tabs and adds new according to the BP https://blueprints.launchpad.net/linaro-android-infrastructure/+spec/rearrange-android-build-tabs
It uses the same approach and codebase as current http://android-build.linaro.org
New groups were created in LP based on discussion with Vishal. To be able to view appropriate builds user needs to be a member of corresponding group.
All existing builds are accessible under "Engineer Builds" tab (Daily+Release tabs) but in future will contain new engineering builds. "Archive Bulids" tab contains also all builds and in future will contain "old" builds.

To post a comment you must log in.
Revision history for this message
Milo Casagrande (milo) wrote :

Hello Georgy!

All in all changes look good.

A couple of things though:
- As said on IRC, with Chrome (23...), I cannot see the tabs, I just see plain search entry boxes, cannot understand if it is not loading the CSS or a problem with the JavaScript. I correctly see everything with Firefox. Might also be related to bug 1085007.
- The second strange behavior I see is with Firefox: if I scroll all the way down on the page (https://ec2-23-22-101-107.compute-1.amazonaws.com/), and I try to open one of the link at the bottom of the (like the last one), the page scrolls all the way to the top of the table. It happens if I click or right click on a link in that position: more or less after half the length of the table. Firefox version is 17.0.1.

review: Needs Information
Revision history for this message
Georgy Redkozubov (gesha) wrote :

Milo, thanks for review, answers are below.

> Hello Georgy!
>
> All in all changes look good.
>
> A couple of things though:
> - As said on IRC, with Chrome (23...), I cannot see the tabs, I just see plain
> search entry boxes, cannot understand if it is not loading the CSS or a
> problem with the JavaScript. I correctly see everything with Firefox. Might
> also be related to bug 1085007.

Yes, this is the same issue. Generally speaking, requests from a HTTPS site should always hit other HTTPS sites (otherwise we'll see insecure content warnings, or requests get blocked as we've discovered). So that's the problem.

> - The second strange behavior I see is with Firefox: if I scroll all the way
> down on the page (https://ec2-23-22-101-107.compute-1.amazonaws.com/), and I
> try to open one of the link at the bottom of the (like the last one), the page
> scrolls all the way to the top of the table. It happens if I click or right
> click on a link in that position: more or less after half the length of the
> table. Firefox version is 17.0.1.

This issue is because there are none of these builds on our development instance :) if you create new user build and click on it from the index page you'll get the correct page :)

Revision history for this message
Milo Casagrande (milo) wrote :

We should find a solution though for bug 1085007, but these changes are independent from that.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches