Merge lp://qastaging/~linaro-infrastructure/linaro-ci/fix_bug_907295 into lp://qastaging/linaro-ci

Looks fine to me.

Adding the line to accept the license in jenkins_common_lib.
This is required otherwise wget is downloading the origen html file instead of the compressed origen hwpack.

Hi,

In jenkins_common_lib, you can replace:

68 if test $hwpack_type = "origen" ; then
69 bzr branch lp:~dooferlad/+junk/download_through_license
70 python download_through_license/download_yes_to_lic.py $latest_kernel
71 fi
72 wget -c $latest_kernel

With just one line:
download_through_license/download_yes_to_lic.py $latest_kernel

That is assuming that jenkins_common_lib has been checked out as part of the complete branch. download_yes_to_lic.py should be fine being run as a script directly as long as it has execute permissions and will download any file that isn't license protected just as happily as license protected ones, so you can replace wget. You shouldn't assume that download_yes_to_lic.py will stay in a junk repository. If we are going to use it, we should put it somewhere permanent and reference that. We can have it in linaro-ci and if it is used elsewhere put it in a shared repository later.

I am sure you know better than I if the above comment is useful or not, so feel free to ignore it if there is a good reason to and check in!

James

On Sat, Jan 7, 2012 at 1:30 AM, James Tunnicliffe
<email address hidden>wrote:

> Review: Approve
>
> Hi,
>
> In jenkins_common_lib, you can replace:
>
> 68 if test $hwpack_type = "origen" ; then
> 69 bzr branch lp:~dooferlad/+junk/download_through_license
> 70 python download_through_license/download_yes_to_lic.py
> $latest_kernel
> 71 fi
> 72 wget -c $latest_kernel
>
> With just one line:
> download_through_license/download_yes_to_lic.py $latest_kernel
>
> That is assuming that jenkins_common_lib has been checked out as part of
> the complete branch. download_yes_to_lic.py should be fine being run as a
> script directly as long as it has execute permissions and will download any
> file that isn't license protected just as happily as license protected
> ones, so you can replace wget. You shouldn't assume that
> download_yes_to_lic.py will stay in a junk repository. If we are going to
> use it, we should put it somewhere permanent and reference that. We can
> have it in linaro-ci and if it is used elsewhere put it in a shared
> repository later.
>
> I am sure you know better than I if the above comment is useful or not, so
> feel free to ignore it if there is a good reason to and check in!
>
>
Thanks a lot for the review.

> James
> --
>
> https://code.launchpad.net/~linaro-infrastructure/linaro-ci/fix_bug_907295/+merge/87725<https://code.launchpad.net/%7Elinaro-infrastructure/linaro-ci/fix_bug_907295/+merge/87725>
> You proposed lp:~linaro-infrastructure/linaro-ci/fix_bug_907295 for
> merging.
>

--
Thanks!!!
Deepti