Drizzle

Merge lp://qastaging/~linuxjedi/drizzle/drizzle-gcc-4.7.0 into lp://qastaging/drizzle

  1. drizzle-gcc-4.7.0
  2. Merge into 7.2
Proposed by Andrew Hutchings
Status: Merged
Merge reported by: Brian Aker
Merged at revision: not available
Proposed branch: lp://qastaging/~linuxjedi/drizzle/drizzle-gcc-4.7.0
Merge into: lp://qastaging/drizzle
Diff against target: 86 lines (+10/-10)
1 file modified
drizzled/drizzled.cc (+10/-10)
To merge this branch: bzr merge lp://qastaging/~linuxjedi/drizzle/drizzle-gcc-4.7.0
Reviewer Review Type Date Requested Status
Olaf van der Spek (community) Needs Fixing
Drizzle Trunk Pending
Review via email: mp+102983@code.qastaging.launchpad.net

Description of the change

Fixes for GCC 4.7.0. This combined with the bison fix makes us good for Fedora 17 compiling.

To post a comment you must log in.
Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

Hi Andrew,

Why not update MAX_MEM_TABLE_SIZE to fix in int64?

review: Needs Fixing
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

well, really the fact that the variable in the struct is an int64_t probably more of an issue. As far as the visual representation is concerned we want these to be uint64.

Revision history for this message
Olaf van der Spek (olafvdspek) wrote :

Why? Are values this big needed?
Are negative values never used?

Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

bigger than uint32_t, yes. Most of these are positive only (such as memory size)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches