LAVA Android Test

Merge lp://qastaging/~liuyq0307/lava-android-test/sdcard-mounted into lp://qastaging/lava-android-test

  1. sdcard-mounted
  2. Merge into trunk
Proposed by Yongqin Liu
Status: Superseded
Proposed branch: lp://qastaging/~liuyq0307/lava-android-test/sdcard-mounted
Merge into: lp://qastaging/lava-android-test
Diff against target: 94 lines (+69/-3)
2 files modified
lava_android_test/test_definitions/hostshells/example.sh (+4/-3)
lava_android_test/test_definitions/hostshells/sdcard-mounted.sh (+65/-0)
To merge this branch: bzr merge lp://qastaging/~liuyq0307/lava-android-test/sdcard-mounted
Reviewer Review Type Date Requested Status
Linaro Validation Team Pending
Review via email: mp+123696@code.qastaging.launchpad.net

This proposal has been superseded by a proposal from 2012-09-13.

Description of the change

add test for checking if the sdcard partition is mounted

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

50 + echo "Usage $0 [--serial|-s serial]"

I'd say this is confusing/incorrect as both options can consume optional argument.

In addition $0 is whatever was execed (which is fine) but it tends to be long (/usr/bin/foobar)

Revision history for this message
Andy Doan (doanac) wrote :

On 09/12/2012 07:13 AM, Zygmunt Krynicki wrote:
> In addition $0 is whatever was execed (which is fine) but it tends to be long (/usr/bin/foobar)

funny, I've always been a fan of $0 there because it can help debugging
odd things at times :) Hadn't thought of that perspective.

Revision history for this message
Antonio Terceiro (terceiro) wrote :

Zygmunt Krynicki escreveu:
> In addition $0 is whatever was execed (which is fine) but it tends to
> be long (/usr/bin/foobar)

I usually use $(basename $0) to avoid very long names.

lp://qastaging/~liuyq0307/lava-android-test/sdcard-mounted updated
207. By Yongqin Liu

use $(basename $0) instead of $0 in usage

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> 50 + echo "Usage $0 [--serial|-s serial]"
>
> I'd say this is confusing/incorrect as both options can consume optional
> argument.
sorry, why you say that's confusing/incorrect?
by that I just want to say that we support both follow commands:
  sdcard-mounted.sh --serial serial
  sdcard-mounted.sh --s serial

And I just borrow this code from lava-partition-disk in lp:lava-master-image-scripts,
did not see the difference between the usage of them.:(

> In addition $0 is whatever was execed (which is fine) but it tends to be long
> (/usr/bin/foobar)
changed to use $(basename $0)

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

W dniu 13.09.2012 04:05, Yongqin Liu pisze:
>> 50 + echo "Usage $0 [--serial|-s serial]"
>>
>> I'd say this is confusing/incorrect as both options can consume optional
>> argument.
> sorry, why you say that's confusing/incorrect?
> by that I just want to say that we support both follow commands:
> sdcard-mounted.sh --serial serial
> sdcard-mounted.sh --s serial

The fact that they take an optional argument.

Sorry for making my previous argument confusing, I would just use
something like this instead:

Usage: sdcard-mounted.sh [OPTIONS]

Available options:

    -s [SERIAL] | --serial [SERIAL]
  The serial device to connect to.
  TODO: Describe what is the default value
  when --serial|-s is passed without an argument

>> In addition $0 is whatever was execed (which is fine) but it tends to be long
>> (/usr/bin/foobar)
> changed to use $(basename $0)

I second that, $(basename $0) is a simple solution

Thanks
ZK

lp://qastaging/~liuyq0307/lava-android-test/sdcard-mounted updated
208. By Yongqin Liu

update the usage style

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches