Merge lp://qastaging/~liuyq0307/lava-android-test/support-testprovider into lp://qastaging/lava-android-test

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 182
Proposed branch: lp://qastaging/~liuyq0307/lava-android-test/support-testprovider
Merge into: lp://qastaging/lava-android-test
Diff against target: 889 lines (+427/-203)
14 files modified
MANIFEST.in (+1/-0)
doc/usage.rst (+49/-20)
lava_android_test/commands.py (+10/-10)
lava_android_test/provider.py (+238/-0)
lava_android_test/test_definitions/bluetooth.py (+1/-49)
lava_android_test/test_definitions/commands/example.py (+23/-0)
lava_android_test/test_definitions/commands/tjunittest.py (+23/-0)
lava_android_test/test_definitions/instruments/example.py (+22/-0)
lava_android_test/test_definitions/memtester.py (+0/-1)
lava_android_test/test_definitions/mmtest.py (+1/-49)
lava_android_test/test_definitions/shells/__init__.py (+2/-0)
lava_android_test/test_definitions/shells/example.sh (+4/-0)
lava_android_test/test_definitions/wifi.py (+1/-49)
lava_android_test/testdef.py (+52/-25)
To merge this branch: bzr merge lp://qastaging/~liuyq0307/lava-android-test/support-testprovider
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email: mp+110650@code.qastaging.launchpad.net

Description of the change

make the following 3 types test integration into lava-android-test easier than before.
1. Instrumentation test, run like “adb shell am instrument ...”
2. Android command test, run like “adb shell test-command”. like the tjunittest/memtest/iozone
3. Android shell test, need to write a shell and run like “adb shell script.sh”

To post a comment you must log in.
Revision history for this message
Andy Doan (doanac) wrote :

looks like the new class "CommonTestProvider(TestProvider)" isn't used anywhere. Can we remove that?

otherwise - I think it looks good, but I didn't do any testing

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

> looks like the new class "CommonTestProvider(TestProvider)" isn't used
> anywhere. Can we remove that?
282 + if name != 'CommonTestProvider':
No, it is used here, use this provider to substitute the testloader method in
lava_android_test/testdef.py, where we load the test definitions now.

Revision history for this message
Andy Doan (doanac) wrote :

okay - sounds good then

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches