Merge lp://qastaging/~liuyq0307/linaro-android-build-tools/support-http into lp://qastaging/linaro-android-build-tools
Proposed by
Yongqin Liu
| Status: | Merged |
|---|---|
| Merged at revision: | 501 |
| Proposed branch: | lp://qastaging/~liuyq0307/linaro-android-build-tools/support-http |
| Merge into: | lp://qastaging/linaro-android-build-tools |
| Diff against target: |
84 lines (+33/-16) 1 file modified
build-scripts/post-build-lava.py (+33/-16) |
| To merge this branch: | bzr merge lp://qastaging/~liuyq0307/linaro-android-build-tools/support-http |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Paul Sokolovsky | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-08-13.
Description of the change
1. Add support to submit job to non-https lava-server instances
2. Change to use LAVA_TOKEN_FILE instead of LAVA_TOKEN to get the token information,
and make it the only the name of the token file, not including any directory path
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks pretty good, thanks for making sure that proper URL schema is used throughout.
The only problem is at line 48. I proposed that value of LAVA_TOKEN_FILE would be just a filename of file containing a token, relative to the predefined dir (/var/run/lava/), not absolute path name. I don't think it's worth to expose full path name to lava tokens in the public build configs.