Merge lp://qastaging/~logan/ubuntu/raring/android-tools/fix-ftbfs into lp://qastaging/ubuntu/raring-proposed/android-tools

Proposed by Logan Rosen
Status: Merged
Merge reported by: Daniel T Chen
Merged at revision: not available
Proposed branch: lp://qastaging/~logan/ubuntu/raring/android-tools/fix-ftbfs
Merge into: lp://qastaging/ubuntu/raring-proposed/android-tools
Diff against target: 43 lines (+11/-4)
2 files modified
debian/changelog (+7/-0)
debian/control (+4/-4)
To merge this branch: bzr merge lp://qastaging/~logan/ubuntu/raring/android-tools/fix-ftbfs
Reviewer Review Type Date Requested Status
Daniel T Chen Approve
Review via email: mp+155594@code.qastaging.launchpad.net

This proposal supersedes a proposal from 2013-03-26.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote : Posted in a previous version of this proposal

On Tue, Mar 26, 2013 at 06:44:21PM -0000, Logan Rosen wrote:
> + * debian/control: Comment out errant Architecture field to fix FTBFS.

Firstly, remove it rather than commenting it out.

Secondly, in order to fulfil the intent of 4.2.2+git20130218-3, it looks
as though you should edit android-tools-adb's Architecture field, and
move the "requires porting ..." comment down to be attached to it.

Revision history for this message
Daniel T Chen (crimsun) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: