Nux

Merge lp://qastaging/~loic.molinari/nux/nux-keyboard-navigation into lp://qastaging/nux

Proposed by Loïc Molinari
Status: Merged
Merged at revision: 190
Proposed branch: lp://qastaging/~loic.molinari/nux/nux-keyboard-navigation
Merge into: lp://qastaging/nux
Diff against target: 140 lines (+53/-18)
5 files modified
Nux/BaseWindow.cpp (+9/-1)
Nux/BaseWindow.h (+1/-0)
Nux/InputArea.cpp (+37/-10)
NuxGraphics/GraphicsDisplayX11.cpp (+0/-6)
NuxGraphics/XInputWindow.cpp (+6/-1)
To merge this branch: bzr merge lp://qastaging/~loic.molinari/nux/nux-keyboard-navigation
Reviewer Review Type Date Requested Status
Jay Taoko (community) Approve
Review via email: mp+47539@code.qastaging.launchpad.net
To post a comment you must log in.
190. By Loïc Molinari

Fixed badly statically defined text string size

Revision history for this message
Jay Taoko (jaytaoko) wrote :

Is the following test:
if (ievent.e_event == NUX_WINDOW_ENTER_FOCUS)
....

meant for input windows that become active without a mouse press on them? As if the window was made active procedurally (rather than following a physical action with the mouse).

review: Needs Information
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Yes, it's meant for that. Unity now procedurally moves the input focus when the user triggers the right key binding (Alt-F1).

Revision history for this message
Jay Taoko (jaytaoko) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches