Merge lp://qastaging/~loic.molinari/qtmir/qtmir-minimize-node-updates into lp://qastaging/qtmir

Proposed by Loïc Molinari
Status: Work in progress
Proposed branch: lp://qastaging/~loic.molinari/qtmir/qtmir-minimize-node-updates
Merge into: lp://qastaging/qtmir
Prerequisite: lp://qastaging/~loic.molinari/qtmir/multi-bufferstream-support-fixes
Diff against target: 227 lines (+86/-21)
5 files modified
src/modules/Unity/Application/mirsurface.cpp (+23/-15)
src/modules/Unity/Application/mirsurface.h (+3/-2)
src/modules/Unity/Application/mirsurfaceinterface.h (+12/-3)
src/modules/Unity/Application/mirsurfaceitem.cpp (+34/-1)
src/modules/Unity/Application/mirsurfaceitem.h (+14/-0)
To merge this branch: bzr merge lp://qastaging/~loic.molinari/qtmir/qtmir-minimize-node-updates
Reviewer Review Type Date Requested Status
Unity8 CI Bot (community) continuous-integration Needs Fixing
PS Jenkins bot (community) continuous-integration Needs Fixing
Mir development team Pending
Review via email: mp+276504@code.qastaging.launchpad.net

Commit message

Optimized CPU usage by removing useless node updates in updatePaintNode().

Description of the change

Optimized CPU usage by removing useless node updates in updatePaintNode().

To post a comment you must log in.
Revision history for this message
Loïc Molinari (loic.molinari) wrote :

Note that this MR requires the multi buffer stream MR [1] from RAOF (with my fixes proposal [2] applied) to be merged.

[1] https://code.launchpad.net/~raof/qtmir/multi-bufferstream-support/+merge/274517
[2] https://code.launchpad.net/~loic.molinari/qtmir/multi-bufferstream-support-fixes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:397
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/9/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-qtmir-1-ci/9/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

397. By Loïc Molinari

Minimized node updates.

396. By Loïc Molinari

Removed useless texture provider header.

395. By Loïc Molinari

Respected project style for function parameters wrapping.

394. By Loïc Molinari

Switched back to stretched fill mode.

393. By Loïc Molinari

Flattened subtree by removing transform nodes, position now directly set on geometry.

392. By Loïc Molinari

Ensured nodes are deleted when shrinking renderables.

391. By Loïc Molinari

Avoid iterating the nodes twice when there are new buffers available.

390. By Loïc Molinari

Fixed broken rendering in spread mode when AA is enabled.

389. By Loïc Molinari

Removed useless markDirty call.

388. By Loïc Molinari

Merged lp:qtmir.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches