Merge lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-export-script-improvement into lp://qastaging/ubuntu-ui-toolkit/staging

Proposed by Loïc Molinari
Status: Work in progress
Proposed branch: lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-export-script-improvement
Merge into: lp://qastaging/ubuntu-ui-toolkit/staging
Diff against target: 130 lines (+63/-16)
5 files modified
README (+11/-9)
export_modules_dir.sh (+1/-5)
gallery.sh (+4/-1)
run_tests.sh (+3/-1)
uitk_shell.sh (+44/-0)
To merge this branch: bzr merge lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-export-script-improvement
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
PS Jenkins bot continuous-integration Needs Fixing
Benjamin Zeller Approve
Zsombor Egri Pending
Review via email: mp+278028@code.qastaging.launchpad.net

Commit message

Added a script to spawn a dedicated UITK shell.

The script exports all the needed environment variables for developers working on the toolkit by reusing the existing export_modules_dir.sh script.

Description of the change

Added a script to spawn a dedicated UITK shell.

The script exports all the needed environment variables for developers working on the toolkit by reusing the existing export_modules_dir.sh script.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Benjamin Zeller (zeller-benjamin) wrote :

LGTM

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/9/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/9/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :

FAILED: Autolanding.
Approved revid is not set in launchpad. This is most likely a launchpad issue and re-approve should fix it. There is also a chance (although a very small one) this is a permission problem of the ps-jenkins bot.
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-autolanding/24/
Executed test runs:
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-land-mp/24/console

review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) :
review: Approve (continuous-integration)

Unmerged revisions

1725. By Loïc Molinari

Fixed typo in the README.

1724. By Loïc Molinari

Updated README.

1723. By Loïc Molinari

Do not override LD_LIBRARY_PATH.

1722. By Loïc Molinari

Made uitk shell and env var export scripts compatible.

1721. By Loïc Molinari

Added script spawning a new shell with all the needed env vars.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches