Ubuntu UI Toolkit

Merge lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-use-set-implicit-size into lp://qastaging/ubuntu-ui-toolkit/staging

  1. ubuntu-ui-toolkit-use-set-implicit-size
  2. Merge into staging
Proposed by Loïc Molinari
Status: Work in progress
Proposed branch: lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-use-set-implicit-size
Merge into: lp://qastaging/ubuntu-ui-toolkit/staging
Prerequisite: lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-resolution-independance
Diff against target: 22 lines (+2/-4)
1 file modified
modules/Ubuntu/Components/plugin/ucubuntushape.cpp (+2/-4)
To merge this branch: bzr merge lp://qastaging/~loic.molinari/ubuntu-ui-toolkit/ubuntu-ui-toolkit-use-set-implicit-size
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu SDK team Pending
Review via email: mp+251893@code.qastaging.launchpad.net

Commit message

[UbuntuShape] Code clean up.

Made use of a single QQuickItem::setImplicitSize() call instead of two QQuickItem::setImplicitWidth() and QQuickItem::setImplicitHeight() calls.

Description of the change

[UbuntuShape] Code clean up.

Made use of a single QQuickItem::setImplicitSize() call instead of two QQuickItem::setImplicitWidth() and QQuickItem::setImplicitHeight() calls.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1341
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1521/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1661/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-amd64-ci/248/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-armhf-ci/251/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-vivid-i386-ci/248/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1659/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/1521/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

1341. By Loïc Molinari

Made use of setImplicitSize instead of setImplicit[Width,Height].

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches