lp://qastaging/~lool/linaro-image-tools/missing-sbin
- Get this branch:
- bzr branch lp://qastaging/~lool/linaro-image-tools/missing-sbin
Branch merges
- Guilherme Salgado (community): Approve
-
Diff: 117 lines (+41/-5)4 files modifiedlinaro_image_tools/cmd_runner.py (+14/-0)
linaro_image_tools/hwpack/packages.py (+5/-3)
linaro_image_tools/tests/test_cmd_runner.py (+21/-0)
linaro_image_tools/utils.py (+1/-2)
Related bugs
Bug #709517: testsuite fails when /sbin missing from PATH | Medium | Fix Released |
Related blueprints
Branch information
Recent revisions
- 311. By Loïc Minier
-
Expose default path of sanitize_path() as to help testing and add tests for
sanitize_path(). - 307. By Loïc Minier
-
Bug: find_command() was setting os.environ['PATH'] to ":/bin:usr/bin" if unset,
but this means that the current directory was searched first unconditionally
even when calling linaro-image-tools system-wide. Later logic in
find_command() correctly prepends the current directory when needed, so it was
useless and incorrect to include . in the PATH by default. - 305. By Loïc Minier
-
Fix handling of empty PATH; this actually means that the current directory
should be searched, and not that PATH is empty. - 304. By Loïc Minier
-
Actually make sure that any of the directories typically found in the PATH are
added if missing; this will ensure that commands which we call and which are
typically in /usr/bin are also in the PATH, and that commands from
linaro-image-tools which might have been installed under /usr/local are also in
the PATH. - 303. By Loïc Minier
-
Move PATH sanitization to a function and call that from Popen.__init__(); note
that:
- this regresses the hwpack testsuite as it uses subprocess.Popen directly, so
that a broken PATH might not be fixed up
- due to the media_create code doing a os.environ.copy() before os.environ
being sanitized, this requires sanitizing both os.environ and the env copy
passed to Popen() - 302. By Loïc Minier
-
Set os.environ['PATH'] if unset or empty; append /sbin to it if missing;
LP: #709517.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://qastaging/linaro-image-tools/11.11