lp:~ltrager/maas

Author: Lee Trager
Author Date: 2021-06-09 23:35:49 UTC

adam-collard fixes

Author: Lee Trager
Author Date: 2021-05-12 22:20:49 UTC

LP: #1927657 - Always include the default kernel command line options

Author: Lee Trager
Author Date: 2021-05-12 18:22:54 UTC

ack fix

Author: Lee Trager
Author Date: 2021-05-11 00:09:02 UTC

Merge branch '2.7' into grub_debug_2.7

Author: Lee Trager
Author Date: 2021-05-10 22:25:27 UTC

LP: #1923268 - Make default grub.cfg architecture agnostic.

Backport of f606805

Author: Lee Trager
Author Date: 2021-05-10 15:11:58 UTC

Remove linuxefi and initrdefi from GRUB configuration.

The linuxefi and initrdefi have been deprecated from GRUB. They are
currently aliased to the linux and initrd command and will soon be removed
from GRUB. This allows MAAS to unify its ephemeral GRUB configuration
across all architectures. The "install" GRUB configuration files have been
removed. They were for installing with Debian installer which is no longer
supported.

Backport of 4f6ac0c

Author: Lee Trager
Author Date: 2021-05-10 21:17:44 UTC

Merge branch '2.8' into lp1923268_2.8

Author: Lee Trager
Author Date: 2021-05-10 19:48:03 UTC

Fix typo

Author: Lee Trager
Author Date: 2021-05-06 21:38:26 UTC

Remove linuxefi and initrdefi from GRUB configuration.

The linuxefi and initrdefi have been deprecated from GRUB. They are
currently aliased to the linux and initrd command and will soon be removed
from GRUB. This allows MAAS to unify its ephemeral GRUB configuration
across all architectures. The "install" GRUB configuration files have been
removed. They were for installing with Debian installer which is no longer
supported.

Backport of 4f6ac0c

Author: Lee Trager
Author Date: 2021-05-08 00:49:14 UTC

Work around LP:1865515 for Ubuntu.

When GRUB chainboots to another signed SHIM the chain of trust is broken. This
causes SecureBoot to halt the system. To work around this bug on Ubuntu
chainload local GRUB directly as the network SHIM already has Canonical's boot
keys.

This will not fix SecureBoot on other operating system and relies on the SHIM
in the MAAS stream to use the same signing key for all Ubuntu releases.

Author: Lee Trager
Author Date: 2021-05-07 00:25:32 UTC

Add GRUB mapping for PPC64EL

Author: Lee Trager
Author Date: 2021-05-07 00:31:37 UTC

Merge branch '2.9' into grub_debug_2.9

Author: Lee Trager
Author Date: 2021-05-07 00:25:32 UTC

Add GRUB mapping for PPC64EL

Author: Lee Trager
Author Date: 2021-05-06 00:07:15 UTC

Remove the GetBootSources V1 RPC call.

Author: Lee Trager
Author Date: 2021-05-05 23:42:14 UTC

Remove DHCP configure and validate V1 RPC calls.

Author: Lee Trager
Author Date: 2021-05-05 22:30:34 UTC

Remove ListBootImagesV1 RPC call.

ListBootImagesV2 was added in MAAS 1.7. Every supported version of MAAS has
the V2 call. No unsupported version of MAAS that old could connect to a
recent version of MAAS.

Author: Alberto Donato
Author Date: 2021-04-20 10:21:30 UTC

drop useless cat in snap install hook

Backport of 0cf756

Author: Lee Trager
Author Date: 2021-04-07 18:27:26 UTC

Remove linuxefi and initrdefi from GRUB configuration.

The linuxefi and initrdefi have been deprecated from GRUB. They are
currently aliased to the linux and initrd command and will soon be removed
from GRUB. This allows MAAS to unify its ephemeral GRUB configuration
across all architectures. The "install" GRUB configuration files have been
removed. They were for installing with Debian installer which is no longer
supported.

Backport of 4f6ac0c

Author: Lee Trager
Author Date: 2021-05-04 23:55:57 UTC

LP: #1923268 - Make default grub.cfg architecture agnostic.

Author: Lee Trager
Author Date: 2021-05-04 21:31:22 UTC

Merge branch 'master' into disable_boot_architectures_postgres_rpc

Author: Lee Trager
Author Date: 2021-05-04 20:53:21 UTC

Fix subnet form tests

Author: Lee Trager
Author Date: 2021-05-04 00:30:06 UTC

Use f-strings

Author: Lee Trager
Author Date: 2021-05-03 23:00:29 UTC

Fix failing test

Author: Lee Trager
Author Date: 2021-05-03 20:48:13 UTC

Merge branch 'master' into disable_boot_architectures_model

Author: Lee Trager
Author Date: 2021-04-28 03:06:47 UTC

Add Subnet websocket handler support for disable_boot_architectures

Author: Lee Trager
Author Date: 2021-04-28 02:53:18 UTC

Set unique identifiable names for boot methods.

Make sure each boot method has a unique name which describes the boot method.
Users will now be able to use this name to prevent isc-dhcpd from responding
to requests for that name, boot octet, or hex value. Each boot method now
corresponds to a single boot octet and bootloader_arches have been set for
all boot methods.

Author: Lee Trager
Author Date: 2021-04-27 19:55:58 UTC

ack fix

Author: Lee Trager
Author Date: 2021-04-23 01:49:25 UTC

LP: #1923867 - Delete old NodeDevices when the PCI address changes.

PCI addresses are unque on a system. If a device is added this address may
change. When detected delete any NodeDevice assoicated with a block device
or interface before creating a new one.

Author: Lee Trager
Author Date: 2021-04-21 04:28:10 UTC

Enable iPXE on any architecture.

When iPXE is the booting client it sends both the architecture code and a
user-class of "iPXE". Always respond to the iPXE client with iPXE config
regardless of architecture.

Author: Lee Trager
Author Date: 2021-04-21 03:18:22 UTC

Automatically fix an incorrect architecture.

When adding a new machine if a user selects the wrong architecture booting will
fail. Every boot architecture except PXE only supports one Debian
architecture. Automatically swap the user selected architecture for the one
detected during boot. Commissioning will properly set the architecture.

Commissioning may still fail due to the archive being set to ports.ubuntu.com
however 50-maas-01-commissioning will still run which will fix the
machine architecture. When a user retries commissioning will work. This is
preferable to failing to load the kernel from the bootloader which can give
a cryptic error message.

Author: Lee Trager
Author Date: 2021-04-15 00:53:53 UTC

Reenable AMD64 UEFI HTTP booting and enable ARM64 UEFI booting.

MAAS will now respond to AMD64 and ARM64 UEFI HTTP boot requests. When booting
over HTTP MAAS will now send a GRUB configuration which will continue to use
the UEFI firmware's internal HTTP stack instead of GRUB's. While various bugs
have been fixed in GRUB's HTTP stack this should avoid any future ones entirely.

Author: Lee Trager
Author Date: 2021-04-15 03:57:35 UTC

Add disabled_boot_architectures configuration option to rackd.conf

Users may now disable boot architectures by adding them to the
disabled_boot_architectures configuration option list. Boot architectures
may be the octet, hex, or name of any boot architecture supported by MAAS.
When disabled MAAS will now respond to boot DHCP requests from the listed
architectures.

Author: Lee Trager
Author Date: 2021-04-13 00:47:51 UTC

Automatically enable VNIC characteristics on S390X when deploying a VM host

S390X partitions do not forward packets over bridges by default. To allow packet
forward VNIC characteristics must be enabled. Do this by default when a VM host
is deployed.

Author: Lee Trager
Author Date: 2021-04-08 20:35:20 UTC

bjornt fixes

Author: Lee Trager
Author Date: 2021-04-07 01:50:00 UTC

Remove linuxefi and initrdefi from GRUB configuration.

The linuxefi and initrdefi have been deprecated from GRUB. They are currently
aliased to the linux and initrd command and will soon be removed from GRUB.
This allows MAAS to unify its ephemeral GRUB configuration across all
architectures. The "install" GRUB configuration files have been removed. They
were for installing with Debian installer which is no longer supported.

Author: Lee Trager
Author Date: 2021-03-30 02:42:38 UTC

LP: #1917652 - Increase timeout for BMC detection commands.

Some BMCs are very slow to respond. Increase the timeout for commands run
by 30-maas-01-bmc-config to 180s so the test doesn't time out.

Cherry-pick of dd3af77

Author: Lee Trager
Author Date: 2021-03-30 00:23:08 UTC

Improve IPMI cipher detection.

Previously IPMI cipher detection tried both bmc-config and ipmitool. This
code would sometimes fail to detect cipher 17. There isn't an advantage to
using both methods as ipmitool will detect 17 and can be used to configure
all ciphers. The ipmitool detection and configuration code has been
refactored and simplified.

Backport of 3961116

Author: Lee Trager
Author Date: 2021-03-30 02:23:52 UTC

Merge branch 'master' into lp1917652

Author: Lee Trager
Author Date: 2021-03-30 01:36:55 UTC

Fix test_get_boot_order_auto_not_deployed

Author: Lee Trager
Author Date: 2021-03-29 18:47:26 UTC

adam-collard fix

Author: Lee Trager
Author Date: 2021-03-29 18:28:45 UTC

adam-collard fixes

Author: Lee Trager
Author Date: 2021-03-23 23:24:47 UTC

Catch unhandled defer

Author: Lee Trager
Author Date: 2021-03-16 01:00:24 UTC

Revert "LP: #1916860 - Check for gaps in supported ciphers when using ipmitool"

This reverts commit 00de313b19a264f47f10700650a1bd033b27e90c.

Author: Lee Trager
Author Date: 2021-03-15 22:57:26 UTC

ack fixes

Author: Lee Trager
Author Date: 2021-03-15 19:32:35 UTC

Merge branch 'master' into set_boot_order_hmcz

Author: Lee Trager
Author Date: 2021-03-15 18:10:29 UTC

Merge branch 'master' into add_set_boot_driver_to_power_drivers

Author: Lee Trager
Author Date: 2021-03-12 02:31:26 UTC

ack fixes

Author: Lee Trager
Author Date: 2021-03-12 02:07:06 UTC

bjornt fixes

Author: Lee Trager
Author Date: 2021-03-08 20:37:13 UTC

Fix failing test

Author: Lee Trager
Author Date: 2021-03-08 18:24:49 UTC

Fix various Proxmox papercuts

* power_vm_name is required
* Fix warnings that a synchronous thread was returning a Deferred() object
* Add log message when no VMs are returned. Proxmox forces you to define
  permissions for a token, if you don't nothing gets returned. Users
  thought this was a MAAS bug.

Backport of c19697f

Author: Lee Trager
Author Date: 2021-03-03 18:07:03 UTC

LP: #1916093 - Fix adding more than one Proxmox BMC and add chassis support

Backport of 0125208

Author: Lee Trager
Author Date: 2021-03-08 18:02:31 UTC

ack fix

Author: Lee Trager
Author Date: 2021-03-04 02:36:59 UTC

LP: #1916860 - Check for gaps in supported ciphers when using ipmitool

Author: Lee Trager
Author Date: 2021-03-03 17:37:02 UTC

adam-collard patch

Author: Lee Trager
Author Date: 2021-03-02 20:27:33 UTC

Merge branch 'master' into hmcz_paused_terminated

Author: Lee Trager
Author Date: 2021-03-02 19:50:39 UTC

bjornt fix

Author: Lee Trager
Author Date: 2021-02-24 19:31:20 UTC

LP: #1916317 - Add web socket function to delete or download Script content

Backport of 6fa37cd

Author: Lee Trager
Author Date: 2021-02-20 02:51:27 UTC

Add boot support for IBM Z Partitions.

Author: Lee Trager
Author Date: 2021-02-22 20:24:34 UTC

LP: #1916317 - Add web socket function to delete or download Script content

Author: Lee Trager
Author Date: 2021-02-19 21:17:35 UTC

GH:LXC/LXD #8477 - Rework block size handling

LXD sources were updated to fix a bug in LXD which incorrectly read the
block size on big endian systems such as S390X. Blocksize was being
unpacked into a 64 bit integer when the kernel was returning a 32 bit
integer.

Author: Lee Trager
Author Date: 2021-02-19 20:27:31 UTC

LP: #1916073 - Include qemu-efi-aarch64 when install_kvm=True on ARM64

Backport of b1b55d2

Author: Lee Trager
Author Date: 2021-02-19 19:43:59 UTC

LP: #1916073 - Include qemu-efi-aarch64 when install_kvm=True on ARM64

Author: Lee Trager
Author Date: 2021-02-18 17:20:12 UTC

LP: #1915970 - Skip Facebook Wedge BMC detection on non-x86 architectures

Facebook Wedge BMC detection uses dmidecode to detect if commissioning is
running on a supported switch. dmidecode is only supported on x86. As
dmidedcode doesn't exist on non-x86 architectures automatically skip
detection on non-x86 architectures.

I discovered this while enabling IBM Z which does not support BMC
detection at all. As such BMC detection is now automatically skipped
on S390X.

Backport of c076fdd

Author: Lee Trager
Author Date: 2021-02-18 00:54:22 UTC

LP: #1915970 - Skip Facebook Wedge BMC detection on non-x86 architectures

Facebook Wedge BMC detection uses dmidecode to detect if commissioning is
running on a supported switch. dmidecode is only supported on x86. As
dmidedcode doesn't exist on non-x86 architectures automatically skip
detection on non-x86 architectures.

I discovered this while enabling IBM Z which does not support BMC detection
at all. As such BMC detection is now automatically skipped on S390X.

Author: Lee Trager
Author Date: 2021-02-17 19:17:31 UTC

adam-collard fix

Author: Lee Trager
Author Date: 2021-02-11 20:03:02 UTC

Fix failing test

Author: Lee Trager
Author Date: 2021-02-11 03:04:38 UTC

Allow a NodeDevice to be replaced by a different device using the same address.

Author: Lee Trager
Author Date: 2021-02-03 01:00:30 UTC

Apply patch from adam-collard

Author: Lee Trager
Author Date: 2021-01-19 18:43:32 UTC

LP: #1911825 - Don't set BMC.ip_address when power_address contains an FQDN

When a BMC is created or edited MAAS maps its IP address to a subnet which
is stored in the model. This allows MAAS to send power commands only to
rack controllers which are on the same subnet as the BMC. If no rack
controller is on the same subnet as the BMC the power command is sent to
all rack controllers. When an FQDN or hostname were given an exception was
raised as MAAS expected an IP address. The exception is now avoided so the
fallback code is used which allow for FQDN or hostnames in the
power_address.

Backport of 19a09e6

Author: Lee Trager
Author Date: 2021-01-20 23:04:17 UTC

LP: #1805799 - Add Proxmox power driver

Backport of 07ce9a2

Author: Lee Trager
Author Date: 2021-01-20 22:49:50 UTC

s/get_running_version/get_maas_version/g

Author: Lee Trager
Author Date: 2021-01-20 22:37:37 UTC

Merge branch 'master' into proxmox

Author: Lee Trager
Author Date: 2021-01-19 19:26:04 UTC

Fix lint

Author: Lee Trager
Author Date: 2021-01-18 22:23:01 UTC

ack fix

Author: Lee Trager
Author Date: 2021-01-13 23:16:01 UTC

ack fixes

Author: Lee Trager
Author Date: 2021-01-07 21:52:21 UTC

GH:lxc/lxd:8308 - LXD resources return null when there are no USB devices

Author: Lee Trager
Author Date: 2021-01-07 18:11:17 UTC

LP: #1910473 - Don't assume NUMA nodes maintain linear continuity.

Cherry pick of ed1ad1bc2

Author: Lee Trager
Author Date: 2021-01-07 10:35:25 UTC

LP: #1910473 - Don't assume NUMA nodes maintain linear continuity.

Cherry pick of ed1ad1bc2

Author: Lee Trager
Author Date: 2021-01-07 02:00:29 UTC

LP: #1910473 - Don't assume NUMA nodes maintain linear continuity.

Author: Lee Trager
Author Date: 2021-01-05 17:17:39 UTC

Merge branch 'master' into node_device_constraints

Author: Lee Trager
Author Date: 2021-01-05 03:48:26 UTC

Add the start time for commissioning, testing, and installation ScriptSets on the websocket.

LP: #1909985

Author: Lee Trager
Author Date: 2021-01-05 01:56:01 UTC

Merge branch 'node_device_api' into node_device_websocket

Author: Lee Trager
Author Date: 2021-01-05 01:55:22 UTC

Merge branch 'process_node_device_data' into node_device_api

Author: Lee Trager
Author Date: 2021-01-05 01:50:56 UTC

adam-collard fixes

Author: Lee Trager
Author Date: 2020-12-16 21:38:26 UTC

ack fix

Author: Lee Trager
Author Date: 2020-12-01 21:19:24 UTC

Validate that release-prepare runs in a branch made for that target.

Author: Lee Trager
Author Date: 2020-11-25 10:21:29 UTC

LP: #1904398 - Only set machines to commissioning in form when anonymous

Backport of 9f03422

Author: Lee Trager
Author Date: 2020-11-25 10:21:29 UTC

LP: #1904398 - Only set machines to commissioning in form when anonymous

Backport of 9f03422

Author: Lee Trager
Author Date: 2020-11-25 04:29:39 UTC

LP: #1904398 - Only set machines to commissioning in form when anonymous

Author: Lee Trager
Author Date: 2020-11-19 03:00:33 UTC

LP: #1904267 - Fallback to reading /sys in get_interfaces()

When migrating enlistment to maas-run-remote-scripts I leveraged
get_interfaces() from network testing to collect the list of MAC
addresses on the system. This code depended on netplan which isn't
available in Xenial. get_interfaces() will now fallback on reading
/sys directly when netplan isn't available.

Author: Lee Trager
Author Date: 2020-09-02 18:40:33 UTC

LP: #1893690 - Remove duplicate hardware UUIDs when detected.

Some Dell hardware uses the service number for the hardware UUID. This
value is not unqiue and causes commissioning to fail. MAAS uses the
hardware UUID to identify the machine when booting. Some hardware like
IBM Z series LPARs only identify themselves this way while PXE booting
tries the UUID first and then falls back on using a MAC address. If a
duplicate is detected remove the UUID from both machines.

Backport of 2f5b2c

Author: Lee Trager
Author Date: 2020-11-17 01:58:44 UTC

LP: #1904329 - Check for SMARTCTL support using alternative string

Author: Lee Trager
Author Date: 2020-11-10 00:37:32 UTC

Fix lint

Author: Lee Trager
Author Date: 2020-10-16 23:31:26 UTC

Change the default commissioning OS to 20.04 LTS, Focal, on new installations.

The libvirt-bin metapackage was deprecated in 18.04 and removed from 20.04.
MAAS now installs libvirt-daemon-system and libvirt-clients which were
previously installed by libvirt-bin. qemu-efi is no longer installed as MAAS
does not compose UEFI VMs with libvirt.

The websocket has also been updated to allow KVM hosts to be deployed on any
Ubuntu version. The API already allowed this.

Author: Lee Trager
Author Date: 2020-11-05 23:27:08 UTC

Retry IPMI power commands without K_g key on K_g key failure.

Some BMCs will claim they are IPMI 2.0 complainant, allow you to set an
IPMI K_g key, allow you to verify an IPMI K_g key is set, yet will deny
any IPMI requests that use an IPMI K_g key. The error given is the K_g
key is invalid. This can be very confusing to users as MAAS allows you
to set an K_g key leaving them to think the only fix is to reset the
machine in person. In this case simply not using an K_g key allows all
IPMI commands to work again.

When there is an IPMI failure which is due to an K_g key and an K_g key
is set MAAS will retry without the K_g key. This is logged as a event
so the user knows what is happening but can still use their machine.

Author: Lee Trager
Author Date: 2020-11-03 19:44:14 UTC

LP: #1887436 - Capture the BMC MAC address when detecting IPMI BMCs

Author: Lee Trager
Author Date: 2020-10-16 07:47:20 UTC

ack fix

Author: Lee Trager
Author Date: 2020-10-08 22:56:05 UTC

Determine and configure the IPMI cipher suite id with bmc-config or ipmitool.

BMC firmware can be buggy and different tools surface these bugs in different
ways. bmc-config works on all machines in the MAAS CI while ipmitool doesn't
detect anything on the ARM64 machine. However a user has reported that ipmitool
detects cipher 17 on his system while bmc-config doesn't. To make sure MAAS
uses the most secure cipher suite id check both.

Author: Lee Trager
Author Date: 2020-10-06 01:50:31 UTC

Verify that an IPMI BMC is configured for secure use.

30-maas-01-bmc-config will now ensure an IPMI BMC is configured to allow
remote use securely. As not all BMCs have all settings missing settings
are quietly ignored. To ensure the BMC isn't overwhelmed with commands
all BMC settings are read and stored at once. MAAS now limits IPMI username,
password, and K_g key to 20 characters.

Author: Lee Trager
Author Date: 2020-09-29 20:04:54 UTC

Merge branch 'master' into bmc_config_parameters