Merge lp://qastaging/~ltrager/maas/fix_websockets_tests_110 into lp://qastaging/maas/1.10
Proposed by
Lee Trager
| Status: | Merged |
|---|---|
| Approved by: | Lee Trager |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 4582 |
| Proposed branch: | lp://qastaging/~ltrager/maas/fix_websockets_tests_110 |
| Merge into: | lp://qastaging/maas/1.10 |
| Diff against target: |
228 lines (+47/-35) 2 files modified
src/maasserver/tests/test_webapp.py (+3/-4) src/maasserver/websockets/tests/test_websockets.py (+44/-31) |
| To merge this branch: | bzr merge lp://qastaging/~ltrager/maas/fix_websockets_tests_110 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Lee Trager (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Stop using deprecated features on the DummyRequest object for twisted 16.
Description of the change
MAAS was using deprecated features from the DummyRequest object during testing. These deprecated features have been removed from Twisted 16 which was just pushed into main on Xenial. I've updated our tests to use the new way which allows our unit tests to pass. I looked around the codebase and it appears that we did convert Requests to the new method awhile back so only the unit tests had to be fixed.
Upstream bugs on removing deprecated features
http://
http://
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Reviewed in https:/