Merge lp://qastaging/~lubuntu-qa/ubuntu-manual-tests/lubuntu-calamares into lp://qastaging/ubuntu-manual-tests

At a quick glance, I see two issues:

 1. You should really double check the formatting (see https://wiki.ubuntu.com/QATeam/ContributingTestcases/ManualStyleGuide/test_case_format_script) since there are at least some closing em tags that have an errant question mark in them.

 2. You should rename the filenames to be human readable, e.g. Install using Calamares (entire disk with encryption, BIOS, no web).

Will look more shortly. Good work!!

1: All were checked by script with no errors.

guiverc@d960-ubu2:/de2900/lubuntu/qa-testing/ubuntu-manual-tests/testcases/image$ test-case-format *.txt
auto-login_after_install.txt
custom_partitioning_on_btrfs.txt
custom_partitioning_on_xfs.txt
custom_partitioning_with_seperate_home.txt
full_disk_install_encypt_bios_noweb.txt
full_disk_install_encypt_bios_waitweb.txt
full_disk_install_encypt_efi_noweb.txt
full_disk_install_encypt_efi_waitweb.txt
full_disk_install_encypt_secefi_noweb.txt
full_disk_install_encypt_secefi_waitweb.txt
full_disk_install_noencypt_bios_noweb.txt
full_disk_install_noencypt_bios_waitweb.txt
full_disk_install_noencypt_efi_noweb.txt
full_disk_install_noencypt_efi_waitweb.txt
full_disk_install_noencypt_secefi_noweb.txt
full_disk_install_noencypt_secefi_waitweb.txt
install_with_existing_partition.txt
Upgrade_using_GUI.txt
Upgrade_using_TUI.txt

test-case-format on my local versions finds no issues, so I'm guessing it's something it didn't pick up & something I missed (this is more likely).

2:
As for human names, Yep. I hate spaces in filenames, so I didn't use any.
If the names are used for more than just the filename containing the file itself; I completely agree & whilst thought it maybe an issue, decided to use names that matched https://phab.lubuntu.me/w/release-team/testing-checklist/ so any missing ones would be easily detected.

I'll aim to look for the extra ? tomorrow, thanks Walter.

 1. Weird, yeah, I guess the script needs improvement. Look at the headers and a few have closing tags with "</em?>." Probably the script just looks for something— anything— between brackets. It really should be limited to letters only.

 2. The most important thing is that it follows the general pattern already in place. In some cases, underscores are used:
https://bazaar.launchpad.net/~ubuntu-testcase/ubuntu-manual-tests/trunk/files/head:/testcases/image/

Some comments about encryption.

Some comments about the location of comment regarding erase disk not showing.

Live should be consistent with the other testcases.

Missing title.

Internet comments.

> + <dd>After ticking the "Encrypt system" radio box, please enter (and confirm) passphrase</dd>
re: `Shouldn't this be followed by a comment to verify that "encrypt system" is checked?`

I wouldn't know what to put, I see a twirly-thingy (on install besides me) then screen returns [unchanged]; [calamares] screen won't allow NEXT until passphrases match. If user unchecks/unticks - they've not done what the last instruction was.

Do we really need to testers to re-check they ticked (word I used instead of checked; would 'checked' be better than 'ticked'?) "Encrypt system". If it was unchecked they'll note it later "You should be required to enter the encryption pass.." (sorry if this is unclear..)

Fair question. Perhaps it might make more logical sense if the "Erase Disk" and "Encrypt System" tasks were two separate ones, i.e. there's two dt tags rather than one.

Okay I get to next comment
> + <dd>Ensure "Encrypt system" checkbox is not ticked</dd>
and yeah it's inconsistent.. (the issue there was the errant NOT)
hmmm -- right now I'd prefer without the line, I'll think awhile..

Don't mix up your TUIs and GUIs.

Glad to see this! I was just thinking about I like the non-English language idea *a lot*. I think we should have one for both the installer and live. I think in both cases, we should try to limit variables, so I think we should make Internet, BIOS, and all default options a requirement.

Next step would be accessibility tests but I don't think any of us have the right hardware. Might be a nice optional test. We can worry about that at a different time, though.

The most urgent thing we should do is implement the bulk of your changes immediately. Go through the diff comments from your last set of commits up to r398 and fix those little quibbles and let's get this up on the ISO tracker!

Thanks again, for your contributions, Chris.

What about unique keyboard layouts? Shouldn't that fall under the localization/internationalization agenda? Again, might be good for a separate merge proposal…

Is this good to merge now?

Brian: no. Unfortunately, Chris has had issues, but is not getting the help he needs:
https://answers.launchpad.net/bzr/+question/688323

guiverc@d960-ubu2:/de2900/lubuntu/qa_testing/ubuntu-manual-tests/testcases/image$ bzr commit -m "Lubuntu 20.04 Calamares install variations"
Committing to: /de2900/lubuntu/qa_testing/ubuntu-manual-tests/
added testcases/image/Auto login
added testcases/image/Custom partitioning on BTRFS
added testcases/image/Custom partitioning on XFS
added testcases/image/Custom partitioning with seperate home
added testcases/image/Full disk install encryption BIOS internet
added testcases/image/Full disk install encryption BIOS offline
added testcases/image/Full disk install encryption EFI internet
added testcases/image/Full disk install encryption EFI offline
added testcases/image/Full disk install encryption SecureEFI internet
added testcases/image/Full disk install encryption SecureEFI offline
added testcases/image/Full disk install no-encryption BIOS internet
added testcases/image/Full disk install no-encryption BIOS offline
added testcases/image/Full disk install no-encryption EFI internet
added testcases/image/Full disk install no-encryption EFI offline
added testcases/image/Full disk install no-encryption SecureEFI internet
added testcases/image/Full disk install no-encryption SecureEFI offline
added testcases/image/Install using another language
added testcases/image/Install with existing partition
added testcases/image/Modern Live
added testcases/image/Upgrade using GUI
added testcases/image/Upgrade using TUI
Committed revision 399.

guiverc@d960-ubu2:/de2900/lubuntu/qa_testing/ubuntu-manual-tests/testcases/image$ bzr push "Lubuntu 20.04 Calamares install variations"
Created new branch.

but still this browser page doesn't reflect what I believe should be here....

Anything done since I re-created my server (.hiddenfiles weren't backed up) isn't reflected by no this page & I can't work out why.

Started again today...
 1002 20/03/17 15:10:27 bzr branch lp:ubuntu-manual-tests
 1003 20/03/17 15:14:36 bzr add Full\ disk*
 1004 20/03/17 15:14:48 adding "testcases/image/Full disk install encryption EFI offline"
 1005 20/03/17 15:15:24 bzr add Custom* Auto\ login Upgrade\ usi*
 1006 20/03/17 15:15:38 bzr add Install\ with\ existing\ partition Install\ using\ another\ language Modern\ Live Replace\ a\ partition
 1007 20/03/17 15:15:48 bzr status
 1008 20/03/17 15:16:47 bzr add Install\ using\ another\ language Install\ with\ existing\ partition Modern\ Live
 1009 20/03/17 15:17:52 bzr status
 1010 20/03/17 15:18:59 bzr commit -m "Lubuntu 20.04 Calamares install variations"
 1011 20/03/17 15:30:50 bzr push "Lubuntu 20.04 Calamares install variations"

I'm missing something and don't know what. I've tried a few times, each time the same.
Today's has committed as 399, but this page says date is 2019-12-31, not wanted 2020-03-17.