Ubuntu
libdebian-installer package

Merge ~lucaskanashiro/ubuntu/+source/libdebian-installer:fix-ftbfs-gcc-10 into ubuntu/+source/libdebian-installer:ubuntu/devel

  1. Git
  2. lp:~lucaskanashiro/ubuntu/+source/libdebian-installer
  3. fix-ftbfs-gcc-10
  4. Merge into ubuntu/devel
Proposed by Lucas Kanashiro
Status: Approved
Approved by: Lucas Kanashiro
Approved revision: 765c4e7438c764fb7cbf8bcf8df4b13817b6e8ca
Proposed branch: ~lucaskanashiro/ubuntu/+source/libdebian-installer:fix-ftbfs-gcc-10
Merge into: ubuntu/+source/libdebian-installer:ubuntu/devel
Diff against target: 42 lines (+10/-2)
3 files modified
debian/changelog (+8/-0)
include/debian-installer/package_internal.h (+1/-1)
include/debian-installer/packages_internal.h (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior (community) Approve
Ubuntu Server Developers Pending
Review via email: mp+388604@code.qastaging.launchpad.net

Description of the change

Fix FTBFS with GCC-10. The reason of this build failure is GCC changing the default from -fcommon to -fno-common. The proposed patch was applied in Debian in the past to fix a GCC-8 build failure, so no need to forward it.

Here is the PPA with the proposed package:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/groovy-libdebian-installer/+packages

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Monday, August 03 2020, Lucas Kanashiro wrote:

> Lucas Kanashiro has proposed merging ~lucaskanashiro/ubuntu/+source/libdebian-installer:fix-ftbfs-gcc-10 into ubuntu/+source/libdebian-installer:ubuntu/devel.
>
> Requested reviews:
> Canonical Server Team (canonical-server)

I'll review this one.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

Reply
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Everything looks good to me, the only minor request I have is to expand the changelog entry and mention that the failure happened because of the change in the compiler behaviour. This might prove useful in the future :-).

Thanks!

review: Needs Fixing
Reply
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the review Sergio, I expanded the changelog entry. Is that good enough now?

Reply
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

That's perfect, thanks Lucas!

review: Approve
Reply
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Great, uploaded:

$ git push pkg upload/0.110ubuntu4
Enumerating objects: 18, done.
Counting objects: 100% (18/18), done.
Delta compression using up to 8 threads
Compressing objects: 100% (11/11), done.
Writing objects: 100% (11/11), 1.37 KiB | 233.00 KiB/s, done.
Total 11 (delta 8), reused 0 (delta 0)
To ssh://git.launchpad.net/ubuntu/+source/libdebian-installer
 * [new tag] upload/0.110ubuntu4 -> upload/0.110ubuntu4

$ dput ubuntu ../libdebian-installer_0.110ubuntu4_source.changes
Checking signature on .changes
gpg: ../libdebian-installer_0.110ubuntu4_source.changes: Valid signature from F823A2729883C97C
Checking signature on .dsc
gpg: ../libdebian-installer_0.110ubuntu4.dsc: Valid signature from F823A2729883C97C
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading libdebian-installer_0.110ubuntu4.dsc: done.
  Uploading libdebian-installer_0.110ubuntu4.tar.xz: done.
  Uploading libdebian-installer_0.110ubuntu4_source.changes: done.
Successfully uploaded packages.

Reply

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches