Indicator Date and Time

Merge lp://qastaging/~lukas-kde/indicator-datetime/convergence into lp://qastaging/indicator-datetime/15.10

  1. convergence
  2. Merge into trunk.15.10
Proposed by Lukáš Tinkl
Status: Merged
Approved by: Nick Dedekind
Approved revision: 428
Merged at revision: 426
Proposed branch: lp://qastaging/~lukas-kde/indicator-datetime/convergence
Merge into: lp://qastaging/indicator-datetime/15.10
Diff against target: 20 lines (+2/-2)
1 file modified
src/menu.cpp (+2/-2)
To merge this branch: bzr merge lp://qastaging/~lukas-kde/indicator-datetime/convergence
Reviewer Review Type Date Requested Status
Nick Dedekind (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+277602@code.qastaging.launchpad.net

Commit message

Display calendar and timezone info in the phone mode as well

Description of the change

Indicator convergence: display the calendar and the timezone info also in the phone mode

According to https://docs.google.com/presentation/d/1W6QO7ARTD4C3bNrgTCWIEvFpYZrAWD3hDUM8mInmHmM/edit?pli=1#slide=id.ge821d0b76_4_18 , design proposes the phone mode also display the aforementioned features.

To post a comment you must log in.
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Commont attached.

review: Needs Information
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

I think there's the PhoneGreeter profile for this case

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:427
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/339/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/29/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/29/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/339/rebuild

review: Needs Fixing (continuous-integration)
lp://qastaging/~lukas-kde/indicator-datetime/convergence updated
428. By Lukáš Tinkl

add the locations specifically for Phone and Desktop only
(w/o greeter profiles)

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

Locations enabled only for non-greeter profiles

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:428
http://jenkins.qa.ubuntu.com/job/indicator-datetime-ci/340/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-amd64-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-datetime-wily-armhf-ci/30/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-ci/340/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Looks fine to me,

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches